search

openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.5k stars 4.7k forks source link

NO-JIRA: Revert #29108 "NO-JIRA: revert restart tests and skip must gathers" #29119

Closed stbenjam closed 2 months ago

stbenjam commented 2 months ago

Reverts #29108 ; tracked by NO-JIRA

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

From what we can tell, these tests are having a high failure rate and likely to reject a payload. See https://github.com/openshift/origin/pull/29108#issuecomment-2361404063 for reccomendation

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

Run /payload blocking jobs to verify aggregation passes

CC: @kannon92

PR created by Revertomatic:tm:
openshift-ci-robot commented 2 months ago

@stbenjam: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/origin/pull/29119): > >Reverts #29108 ; tracked by NO-JIRA > >Per [OpenShift policy](https://github.com/openshift/enhancements/blob/master/enhancements/release/improving-ci-signal.md#quick-revert), we are reverting this breaking change to get CI and/or nightly payloads flowing again. > >From what we can tell, these tests are having a high failure rate and likely to reject a payload > >To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem: > >``` >Run /payload blocking jobs to verify aggregation passes >``` > >CC: @kannon92 > >
>PR created by Revertomatic:tm: >
> Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
neisw commented 2 months ago

/lgtm

stbenjam commented 2 months ago

/override ci/prow/e2e-gcp-ovn /override ci/prow/e2e-gcp-ovn-upgrade /override ci/prow/e2e-metal-ipi-ovn-ipv6 /override ci/prow/e2e-aws-ovn-edge-zones /override ci/prow/e2e-aws-ovn-fips /override ci/prow/e2e-aws-ovn-serial /skip

openshift-ci[bot] commented 2 months ago

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-ovn-edge-zones, ci/prow/e2e-aws-ovn-fips, ci/prow/e2e-aws-ovn-serial, ci/prow/e2e-gcp-ovn, ci/prow/e2e-gcp-ovn-upgrade, ci/prow/e2e-metal-ipi-ovn-ipv6

In response to [this](https://github.com/openshift/origin/pull/29119#issuecomment-2361476601): >/override ci/prow/e2e-gcp-ovn >/override ci/prow/e2e-gcp-ovn-upgrade >/override ci/prow/e2e-metal-ipi-ovn-ipv6 >/override ci/prow/e2e-aws-ovn-edge-zones >/override ci/prow/e2e-aws-ovn-fips >/override ci/prow/e2e-aws-ovn-serial >/skip > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
stbenjam commented 2 months ago

/test unit

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neisw, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/origin/blob/master/OWNERS)~~ [neisw,stbenjam] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 months ago

@stbenjam: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-microshift 14053b8632550260db5853fcbf3b1d883effaff0 link false /test e2e-aws-ovn-microshift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests This PR has been included in build openshift-enterprise-tests-container-v4.18.0-202409200008.p0.gf25349c.assembly.stream.el9. All builds following this will include this PR.