search

openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.5k stars 4.7k forks source link

API-1835: don't allow platform users to make invalid requests #29147

Closed deads2k closed 1 month ago

deads2k commented 2 months ago

We want to catch users making invalid requests to prevent mistakes.

openshift-ci-robot commented 2 months ago

@deads2k: This pull request references API-1835 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/origin/pull/29147): >We want to catch users making invalid requests to prevent mistakes. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/origin/blob/master/OWNERS)~~ [deads2k] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-trt-bot commented 2 months ago

Job Failure Risk Analysis for sha: 28ee8b09430ec5eb12b65ee25deaf8ba70327d13

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-gcp-ovn-upgrade High
[Jira:"kube-apiserver"] monitor test audit-log-analyzer test evaluation
This test has passed 100.00% of 1152 runs on jobs ['periodic-ci-openshift-release-master-ci-4.18-e2e-gcp-ovn-upgrade' 'periodic-ci-openshift-release-master-nightly-4.18-e2e-gcp-ovn-upgrade'] in the last 14 days.
pull-ci-openshift-origin-master-e2e-aws-ovn-upgrade High
[Jira:"kube-apiserver"] monitor test audit-log-analyzer test evaluation
This test has passed 100.00% of 879 runs on jobs ['periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade'] in the last 14 days.
pull-ci-openshift-origin-master-e2e-aws-ovn-microshift-serial High
[Jira:"kube-apiserver"] monitor test audit-log-analyzer test evaluation
This test has passed 100.00% of 104 runs on jobs ['periodic-ci-openshift-microshift-release-4.18-periodics-e2e-aws-ovn-ocp-conformance-serial'] in the last 14 days.
pull-ci-openshift-origin-master-e2e-aws-ovn-microshift High
[Jira:"kube-apiserver"] monitor test audit-log-analyzer test evaluation
This test has passed 100.00% of 108 runs on release 4.18 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:microshift Upgrade:none] in the last week.
pull-ci-openshift-origin-master-e2e-aws-ovn-kube-apiserver-rollout High
[Jira:"kube-apiserver"] monitor test audit-log-analyzer test evaluation
This test has passed 100.00% of 14 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-kube-apiserver-rollout'] in the last 14 days.
pull-ci-openshift-origin-master-e2e-openstack-ovn IncompleteTests
Tests for this run (101) are below the historical average (2564): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6 IncompleteTests
Tests for this run (100) are below the historical average (2275): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn IncompleteTests
Tests for this run (100) are below the historical average (2363): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-gcp-ovn IncompleteTests
Tests for this run (103) are below the historical average (2067): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-gcp-csi IncompleteTests
Tests for this run (103) are below the historical average (1041): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade IncompleteTests
Tests for this run (1422) are below the historical average (3575): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial IncompleteTests
Tests for this run (102) are below the historical average (1184): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node IncompleteTests
Tests for this run (102) are below the historical average (2393): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-fips IncompleteTests
Tests for this run (102) are below the historical average (2562): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-edge-zones IncompleteTests
Tests for this run (103) are below the historical average (2458): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-cgroupsv2 IncompleteTests
Tests for this run (102) are below the historical average (2543): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-csi IncompleteTests
Tests for this run (102) are below the historical average (1217): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-agnostic-ovn-cmd IncompleteTests
Tests for this run (103) are below the historical average (1196): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
openshift-trt-bot commented 2 months ago

Job Failure Risk Analysis for sha: c0b813a4ba7461cac57fbf07dfa2e2799713f8e2

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-kube-apiserver-rollout High
[Jira:"kube-apiserver"] monitor test audit-log-analyzer test evaluation
This test has passed 100.00% of 13 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-kube-apiserver-rollout'] in the last 14 days.
pull-ci-openshift-origin-master-e2e-gcp-ovn-upgrade High
[Jira:"kube-apiserver"] monitor test audit-log-analyzer test evaluation
This test has passed 100.00% of 1155 runs on jobs ['periodic-ci-openshift-release-master-ci-4.18-e2e-gcp-ovn-upgrade' 'periodic-ci-openshift-release-master-nightly-4.18-e2e-gcp-ovn-upgrade'] in the last 14 days.
pull-ci-openshift-origin-master-e2e-gcp-ovn-rt-upgrade High
[Jira:"kube-apiserver"] monitor test audit-log-analyzer test evaluation
This test has passed 100.00% of 309 runs on release 4.18 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:gcp SecurityMode:default Topology:ha Upgrade:micro] in the last week.
pull-ci-openshift-origin-master-e2e-aws-ovn-upgrade High
[Jira:"kube-apiserver"] monitor test audit-log-analyzer test evaluation
This test has passed 100.00% of 901 runs on jobs ['periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade'] in the last 14 days.
pull-ci-openshift-origin-master-e2e-aws-ovn-microshift-serial High
[Jira:"kube-apiserver"] monitor test audit-log-analyzer test evaluation
This test has passed 100.00% of 106 runs on jobs ['periodic-ci-openshift-microshift-release-4.18-periodics-e2e-aws-ovn-ocp-conformance-serial'] in the last 14 days.
pull-ci-openshift-origin-master-e2e-aws-ovn-microshift High
[Jira:"kube-apiserver"] monitor test audit-log-analyzer test evaluation
This test has passed 100.00% of 108 runs on release 4.18 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:microshift Upgrade:none] in the last week.
pull-ci-openshift-origin-master-e2e-aws-ovn-kube-apiserver-rollout High
[Jira:"kube-apiserver"] monitor test audit-log-analyzer test evaluation
This test has passed 100.00% of 13 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-kube-apiserver-rollout'] in the last 14 days.
deads2k commented 1 month ago

Sigh. Looks like some openshift controllers sometimes create invalid resources. We'll have to exclude those

openshift-trt-bot commented 1 month ago

Job Failure Risk Analysis for sha: 69286c2f7fa8cead471aaae1ba6aba4bfcb0cb7a

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-kube-apiserver-rollout Low
[Conformance][Suite:openshift/kube-apiserver/rollout][Jira:"kube-apiserver"][sig-kube-apiserver] kube-apiserver should roll out new revisions without disruption [apigroup:config.openshift.io][apigroup:operator.openshift.io]
This test has passed 64.29% of 14 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-kube-apiserver-rollout'] in the last 14 days.
deads2k commented 1 month ago

https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/29147/pull-ci-openshift-origin-master-e2e-aws-ovn-fips/1841559189369917440 is required and won't pass unless the skips work. Only those two show up in the presubmits.

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 4f88248729e93fed2b6e0396a2f77d89594de798 and 2 for PR HEAD bc8485c4636838236dd221258c4221151d5f95d5 in total

openshift-trt-bot commented 1 month ago

Job Failure Risk Analysis for sha: bc8485c4636838236dd221258c4221151d5f95d5

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-kube-apiserver-rollout Low
[Conformance][Suite:openshift/kube-apiserver/rollout][Jira:"kube-apiserver"][sig-kube-apiserver] kube-apiserver should roll out new revisions without disruption [apigroup:config.openshift.io][apigroup:operator.openshift.io]
This test has passed 64.29% of 14 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-kube-apiserver-rollout'] in the last 14 days.
openshift-ci[bot] commented 1 month ago

New changes are detected. LGTM label has been removed.

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 206be1649d3f42d747c120522448674618cb2ee7 and 2 for PR HEAD 07e05826ddd9ee85ce6d00d7612499bf61e673da in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 206be1649d3f42d747c120522448674618cb2ee7 and 2 for PR HEAD 07e05826ddd9ee85ce6d00d7612499bf61e673da in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 206be1649d3f42d747c120522448674618cb2ee7 and 2 for PR HEAD 07e05826ddd9ee85ce6d00d7612499bf61e673da in total

openshift-ci[bot] commented 1 month ago

New changes are detected. LGTM label has been removed.

openshift-ci[bot] commented 1 month ago

@deads2k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-ovn b5ad9e2786b5cbb343f63fa00b3368cc60ae91ff link false /test e2e-openstack-ovn
ci/prow/e2e-gcp-ovn-rt-upgrade b5ad9e2786b5cbb343f63fa00b3368cc60ae91ff link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-aws-ovn-ipsec-serial b5ad9e2786b5cbb343f63fa00b3368cc60ae91ff link false /test e2e-aws-ovn-ipsec-serial
ci/prow/e2e-aws-ovn-single-node-upgrade b5ad9e2786b5cbb343f63fa00b3368cc60ae91ff link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node-serial b5ad9e2786b5cbb343f63fa00b3368cc60ae91ff link false /test e2e-aws-ovn-single-node-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-trt-bot commented 1 month ago

Job Failure Risk Analysis for sha: b5ad9e2786b5cbb343f63fa00b3368cc60ae91ff

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade Medium
[sig-network-edge] Verify DNS availability during and after upgrade success
This test has passed 94.14% of 239 runs on release 4.18 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:single Upgrade:micro] in the last week.
---
[bz-kube-apiserver][invariant] alert/KubeAPIErrorBudgetBurn should not be at or above info
This test has passed 87.87% of 239 runs on release 4.18 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:single Upgrade:micro] in the last week.

Open Bugs
alert/KubeAPIErrorBudgetBurn should not be at or above info
alert/KubeAPIErrorBudgetBurn should not be at or above info
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests This PR has been included in build openshift-enterprise-tests-container-v4.18.0-202410040439.p0.g5a39d08.assembly.stream.el9. All builds following this will include this PR.