openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.5k stars 4.7k forks source link

API-1689: TLS registry: add refresh period requirement #29215

Closed vrutkovs closed 2 days ago

vrutkovs commented 1 month ago

New cert requirement: refresh period should be specified so that users would be aware how often certificate content is being updated.

TODO: needs https://github.com/openshift/cluster-kube-apiserver-operator/pull/1763 to update autogenerate annotations

openshift-ci-robot commented 1 month ago

@vrutkovs: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/origin/pull/29215): >New cert requirement: refresh period should be specified so that users would be aware how often certificate content is being updated Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vrutkovs Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/origin/blob/master/OWNERS)** - **[tls/violations/OWNERS](https://github.com/openshift/origin/blob/master/tls/violations/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 month ago

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-rt-upgrade 270c9d930e11e72ae8461d87bd1c62389a40850f link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-metal-ipi-ovn-ipv6 270c9d930e11e72ae8461d87bd1c62389a40850f link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-metal-ipi-ovn 270c9d930e11e72ae8461d87bd1c62389a40850f link false /test e2e-metal-ipi-ovn
ci/prow/e2e-aws-ovn-edge-zones 270c9d930e11e72ae8461d87bd1c62389a40850f link true /test e2e-aws-ovn-edge-zones
ci/prow/e2e-aws-ovn-serial 270c9d930e11e72ae8461d87bd1c62389a40850f link true /test e2e-aws-ovn-serial
ci/prow/verify 270c9d930e11e72ae8461d87bd1c62389a40850f link true /test verify
ci/prow/e2e-aws-ovn-single-node-upgrade 270c9d930e11e72ae8461d87bd1c62389a40850f link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout 270c9d930e11e72ae8461d87bd1c62389a40850f link false /test e2e-metal-ipi-ovn-kube-apiserver-rollout

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 3 weeks ago

@vrutkovs: This pull request references API-1689 which is a valid jira issue.

In response to [this](https://github.com/openshift/origin/pull/29215): >New cert requirement: refresh period should be specified so that users would be aware how often certificate content is being updated Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 week ago

@vrutkovs: This pull request references API-1689 which is a valid jira issue.

In response to [this](https://github.com/openshift/origin/pull/29215): >New cert requirement: refresh period should be specified so that users would be aware how often certificate content is being updated. > >TODO: needs https://github.com/openshift/cluster-kube-apiserver-operator/pull/1763 to update autogenerate annotations Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
vrutkovs commented 2 days ago

Included in https://github.com/openshift/origin/pull/29327