openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.53k stars 4.72k forks source link

SDN-4930: Make UserDefinedNetwork status backwards compatible #29446

Closed kyrtapz closed 2 weeks ago

kyrtapz commented 3 weeks ago

https://github.com/ovn-kubernetes/ovn-kubernetes/commit/97d9b67ab59632e3bcebc66049b400c2a096e370

Modified the network condition. This commit makes it backwards compatible so that downstream merge will not be blocked.

/cc @trozet @ormergi @tssurya

kyrtapz commented 3 weeks ago

/testwith openshift/origin/master/e2e-gcp-ovn-techpreview https://github.com/openshift/ovn-kubernetes/pull/2417

openshift-ci-robot commented 3 weeks ago

@kyrtapz: This pull request references SDN-4930 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.19." or "openshift-4.19.", but it targets "openshift-4.18" instead.

In response to [this](https://github.com/openshift/origin/pull/29446): >https://github.com/ovn-kubernetes/ovn-kubernetes/commit/97d9b67ab59632e3bcebc66049b400c2a096e370 > >Modified the network condition. This commit makes it backwards compatible so that downstream merge will not be blocked. > >/cc @trozet @ormergi @tssurya Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
tssurya commented 2 weeks ago

/label acknowledge-critical-fixes-only

tssurya commented 2 weeks ago

/retest-required

knobunc commented 2 weeks ago

/approve

openshift-ci-robot commented 2 weeks ago

/retest-required

Remaining retests: 0 against base HEAD a92836d6f66505ec428fc1b2760667016ca6cd90 and 2 for PR HEAD eb840457ab5342fc5a1191f81178e67a941accf1 in total

tssurya commented 2 weeks ago

/hold Sounds like Tim's PR can merge instead since that's ready We don't want to have to rebase

openshift-trt[bot] commented 2 weeks ago

Job Failure Risk Analysis for sha: eb840457ab5342fc5a1191f81178e67a941accf1

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-serial Medium
[sig-imageregistry][Serial] Image signature workflow can push a signed image to openshift registry and verify it [apigroup:user.openshift.io][apigroup:image.openshift.io] [Skipped:Disconnected] [Suite:openshift/conformance/serial]
This test has passed 97.51% of 281 runs on release 4.19 [Overall] in the last week.
tssurya commented 2 weeks ago

/hold cancel

tssurya commented 2 weeks ago

/hold

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knobunc, kyrtapz, ormergi, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[test/extended/networking/OWNERS](https://github.com/openshift/origin/blob/master/test/extended/networking/OWNERS)~~ [knobunc] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tssurya commented 2 weeks ago

/hold cancel

tssurya commented 2 weeks ago

/hold Sounds like Tim's PR can merge instead since that's ready We don't want to have to rebase

unit tests are failing on that PR... needs another round of pushing

knobunc commented 2 weeks ago

/override ci/prow/e2e-aws-ovn-serial

knobunc commented 2 weeks ago

/prow refresh

openshift-ci[bot] commented 2 weeks ago

@knobunc: Overrode contexts on behalf of knobunc: ci/prow/e2e-aws-ovn-serial

In response to [this](https://github.com/openshift/origin/pull/29446#issuecomment-2602493205): >/override ci/prow/e2e-aws-ovn-serial Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
knobunc commented 2 weeks ago

/tide refresh

knobunc commented 2 weeks ago

Force merged because of known issues with ci/prow/e2e-aws-ovn-serial and image installs that are being worked on separately.

openshift-bot commented 2 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests This PR has been included in build openshift-enterprise-tests-container-v4.19.0-202501201537.p0.g0f2d600.assembly.stream.el9. All builds following this will include this PR.

openshift-ci[bot] commented 2 weeks ago

@kyrtapz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-kube-apiserver-rollout eb840457ab5342fc5a1191f81178e67a941accf1 link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/e2e-aws-ovn-single-node-serial eb840457ab5342fc5a1191f81178e67a941accf1 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-gcp-ovn-rt-upgrade eb840457ab5342fc5a1191f81178e67a941accf1 link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-metal-ipi-ovn eb840457ab5342fc5a1191f81178e67a941accf1 link false /test e2e-metal-ipi-ovn
ci/prow/e2e-aws-ovn-single-node-upgrade eb840457ab5342fc5a1191f81178e67a941accf1 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-gcp-csi eb840457ab5342fc5a1191f81178e67a941accf1 link false /test e2e-gcp-csi
ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout eb840457ab5342fc5a1191f81178e67a941accf1 link false /test e2e-metal-ipi-ovn-kube-apiserver-rollout
ci/prow/e2e-aws-ovn-serial eb840457ab5342fc5a1191f81178e67a941accf1 link unknown /test e2e-aws-ovn-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).