openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.53k stars 4.72k forks source link

NO-JIRA: use quay.io/openshift/origin-cli:latest directly #29466

Closed ricardomaraschini closed 2 weeks ago

ricardomaraschini commented 2 weeks ago

we have the following e2e test failing constantly:

Image signature workflow can push a signed image to openshift registry and verify it

this e2e is failing when attempting to build an image. the reported build failure is as follow:

error: build error: building at STEP "RUN source /etc/os-release && rhel_major=${VERSION_ID%!(BADPREC)%!}(MISSING) && yum config-manager --add-repo "https://cdn-ubi.redhat.com/content/public/ubi/dist/ubi${rhel_major}/${rhel_major}/\$basearch/baseos/os/"     --add-repo "https://cdn-ubi.redhat.com/content/public/ubi/dist/ubi${rhel_major}/${rhel_major}/\$basearch/appstream/os/"":
while running runtime: exit status 6

this error seems to be related to the yum wrapper that has been added to the image.

this pr makes the e2e to use the image directly from the upstream repository (quay), that image does not contain the yum wrapper.

openshift-ci-robot commented 2 weeks ago

@ricardomaraschini: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/origin/pull/29466): >we have the following e2e test failing constantly: > >``` >Image signature workflow can push a signed image to openshift >registry and verify it >``` > >this e2e is failing when attempting to build an image. the reported build failure is as follow: > >``` >error: build error: building at STEP "RUN source /etc/os-release && rhel_major=${VERSION_ID%!(BADPREC)%!}(MISSING) && yum config-manager --add-repo "https://cdn-ubi.redhat.com/content/public/ubi/dist/ubi${rhel_major}/${rhel_major}/\$basearch/baseos/os/" --add-repo "https://cdn-ubi.redhat.com/content/public/ubi/dist/ubi${rhel_major}/${rhel_major}/\$basearch/appstream/os/"": >while running runtime: exit status 6 >``` > >this error seems to be related to the yum wrapper that has been added to the image. > >this pr makes the e2e to use the image directly from the upstream repository (quay), that image does not contain the yum wrapper. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ricardomaraschini commented 2 weeks ago

None of the failed tests is the one we addressed with this PR. Triggering the faulty ones once more.

/retest

joepvd commented 2 weeks ago

/lgtm

openshift-trt[bot] commented 2 weeks ago

Job Failure Risk Analysis for sha: 737ba8eb0ce922723c4089f38e92a7ba22348358

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-hypershift-conformance Medium
[sig-sippy] infrastructure should work
This test has passed 80.83% of 360 runs on release 4.19 [Architecture:amd64 FeatureSet:default Installer:hypershift Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:external Upgrade:none] in the last week.
ricardomaraschini commented 2 weeks ago

/retest

ricardomaraschini commented 2 weeks ago

/assign @neisw

neisw commented 2 weeks ago

/approve

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joepvd, neisw, ricardomaraschini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/origin/blob/master/OWNERS)~~ [neisw] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
neisw commented 2 weeks ago

/label acknowledge-critical-fixes-only

ricardomaraschini commented 2 weeks ago

/retest

openshift-bot commented 2 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests This PR has been included in build openshift-enterprise-tests-container-v4.19.0-202501231838.p0.ga30e8f6.assembly.stream.el9. All builds following this will include this PR.