openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.53k stars 4.72k forks source link

SDN-4930: Fix live migration tests #29477

Closed trozet closed 2 weeks ago

trozet commented 2 weeks ago

Now that we create the namespace for the tests NewCLIWithoutNamespace, implicitly another function is not called:

SetupProject->setupProject/setupNamespace->ChangeUser

ChangeUser will generate kubeconfig for the namespace user and set CLI.configPath. However we dont setup project, so we dont have a proper user account and the other scaffolding for a project. Therefore calling oc.DynamicClient or other OC commands that would use the user CLI.configPath wont work.

This would result in the "failed to open file" error because there was no user kubeconfig written to disk.

Just use admin for now.

trozet commented 2 weeks ago

/retitle SDN-4930: Fix live migration tests

openshift-ci-robot commented 2 weeks ago

@trozet: This pull request references SDN-4930 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.19." or "openshift-4.19.", but it targets "openshift-4.18" instead.

In response to [this](https://github.com/openshift/origin/pull/29477): >Now that we create the namespace for the tests NewCLIWithoutNamespace, implicitly another function is not called: > >SetupProject->setupProject/setupNamespace->ChangeUser > >ChangeUser will generate kubeconfig for the namespace user and set CLI.configPath. However we dont setup project, so we dont have a proper user account and the other scaffolding for a project. Therefore calling oc.DynamicClient or other OC commands that would use the user CLI.configPath wont work. > >Just use admin for now. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
trozet commented 2 weeks ago

/test ?

openshift-ci[bot] commented 2 weeks ago

@trozet: The following commands are available to trigger required jobs:

/test e2e-aws-jenkins
/test e2e-aws-ovn-edge-zones
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-image-registry
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial
/test e2e-gcp-ovn
/test e2e-gcp-ovn-builds
/test e2e-gcp-ovn-image-ecosystem
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test images
/test lint
/test unit
/test verify
/test verify-deps

The following commands are available to trigger optional jobs:

/test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
/test e2e-agnostic-ovn-cmd
/test e2e-aws
/test e2e-aws-csi
/test e2e-aws-disruptive
/test e2e-aws-etcd-certrotation
/test e2e-aws-etcd-recovery
/test e2e-aws-ovn
/test e2e-aws-ovn-cgroupsv2
/test e2e-aws-ovn-etcd-scaling
/test e2e-aws-ovn-ipsec-serial
/test e2e-aws-ovn-kube-apiserver-rollout
/test e2e-aws-ovn-kubevirt
/test e2e-aws-ovn-single-node
/test e2e-aws-ovn-single-node-serial
/test e2e-aws-ovn-single-node-techpreview
/test e2e-aws-ovn-single-node-techpreview-serial
/test e2e-aws-ovn-single-node-upgrade
/test e2e-aws-ovn-upgrade
/test e2e-aws-ovn-upgrade-rollback
/test e2e-aws-ovn-upi
/test e2e-aws-ovn-virt-techpreview
/test e2e-aws-proxy
/test e2e-azure
/test e2e-azure-ovn-etcd-scaling
/test e2e-azure-ovn-upgrade
/test e2e-baremetalds-kubevirt
/test e2e-external-aws
/test e2e-external-aws-ccm
/test e2e-external-vsphere-ccm
/test e2e-gcp-csi
/test e2e-gcp-disruptive
/test e2e-gcp-fips-serial
/test e2e-gcp-ovn-etcd-scaling
/test e2e-gcp-ovn-rt-upgrade
/test e2e-gcp-ovn-techpreview
/test e2e-gcp-ovn-techpreview-serial
/test e2e-hypershift-conformance
/test e2e-metal-ipi-ovn
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-dualstack-local-gateway
/test e2e-metal-ipi-ovn-kube-apiserver-rollout
/test e2e-metal-ipi-serial
/test e2e-metal-ipi-serial-ovn-ipv6
/test e2e-metal-ipi-virtualmedia
/test e2e-metal-ovn-single-node-live-iso
/test e2e-metal-ovn-single-node-with-worker-live-iso
/test e2e-openstack-ovn
/test e2e-openstack-serial
/test e2e-vsphere
/test e2e-vsphere-ovn-dualstack-primaryv6
/test e2e-vsphere-ovn-etcd-scaling
/test okd-e2e-gcp
/test okd-scos-e2e-aws-ovn
/test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-origin-master-e2e-agnostic-ovn-cmd
pull-ci-openshift-origin-master-e2e-aws-csi
pull-ci-openshift-origin-master-e2e-aws-ovn-cgroupsv2
pull-ci-openshift-origin-master-e2e-aws-ovn-edge-zones
pull-ci-openshift-origin-master-e2e-aws-ovn-fips
pull-ci-openshift-origin-master-e2e-aws-ovn-kube-apiserver-rollout
pull-ci-openshift-origin-master-e2e-aws-ovn-microshift
pull-ci-openshift-origin-master-e2e-aws-ovn-microshift-serial
pull-ci-openshift-origin-master-e2e-aws-ovn-serial
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade
pull-ci-openshift-origin-master-e2e-aws-ovn-upgrade
pull-ci-openshift-origin-master-e2e-gcp-csi
pull-ci-openshift-origin-master-e2e-gcp-ovn
pull-ci-openshift-origin-master-e2e-gcp-ovn-rt-upgrade
pull-ci-openshift-origin-master-e2e-gcp-ovn-upgrade
pull-ci-openshift-origin-master-e2e-hypershift-conformance
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-kube-apiserver-rollout
pull-ci-openshift-origin-master-e2e-openstack-ovn
pull-ci-openshift-origin-master-images
pull-ci-openshift-origin-master-lint
pull-ci-openshift-origin-master-okd-scos-e2e-aws-ovn
pull-ci-openshift-origin-master-unit
pull-ci-openshift-origin-master-verify
pull-ci-openshift-origin-master-verify-deps
In response to [this](https://github.com/openshift/origin/pull/29477#issuecomment-2613558068): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
trozet commented 2 weeks ago

/test e2e-aws-ovn-virt-techpreview

openshift-ci-robot commented 2 weeks ago

@trozet: This pull request references SDN-4930 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.19." or "openshift-4.19.", but it targets "openshift-4.18" instead.

In response to [this](https://github.com/openshift/origin/pull/29477): >Now that we create the namespace for the tests NewCLIWithoutNamespace, implicitly another function is not called: > >SetupProject->setupProject/setupNamespace->ChangeUser > >ChangeUser will generate kubeconfig for the namespace user and set CLI.configPath. However we dont setup project, so we dont have a proper user account and the other scaffolding for a project. Therefore calling oc.DynamicClient or other OC commands that would use the user CLI.configPath wont work. > >This would result in the "failed to open file" error because there was no user kubeconfig written to disk. > >Just use admin for now. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
trozet commented 2 weeks ago

/label acknowledge-critical-fixes-only

jluhrsen commented 2 weeks ago

/lgtm

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jluhrsen, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[test/extended/networking/OWNERS](https://github.com/openshift/origin/blob/master/test/extended/networking/OWNERS)~~ [trozet] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 weeks ago

@trozet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn 82c142d72616d2859a0f913f58df5045bb210401 link false /test e2e-metal-ipi-ovn
ci/prow/e2e-aws-ovn-virt-techpreview 82c142d72616d2859a0f913f58df5045bb210401 link false /test e2e-aws-ovn-virt-techpreview
ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout 82c142d72616d2859a0f913f58df5045bb210401 link false /test e2e-metal-ipi-ovn-kube-apiserver-rollout
ci/prow/okd-scos-e2e-aws-ovn 82c142d72616d2859a0f913f58df5045bb210401 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-hypershift-conformance 82c142d72616d2859a0f913f58df5045bb210401 link false /test e2e-hypershift-conformance
ci/prow/e2e-aws-ovn-kube-apiserver-rollout 82c142d72616d2859a0f913f58df5045bb210401 link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/e2e-aws-ovn-single-node-upgrade 82c142d72616d2859a0f913f58df5045bb210401 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-openstack-ovn 82c142d72616d2859a0f913f58df5045bb210401 link false /test e2e-openstack-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 2 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests This PR has been included in build openshift-enterprise-tests-container-v4.19.0-202501250436.p0.g8556b6b.assembly.stream.el9. All builds following this will include this PR.