search

openshift / sriov-network-operator

SR-IOV Network Operator
Apache License 2.0
119 stars 106 forks source link

[release-4.17] OCPBUGS-39400: SCC-pinning for openshift workloads #995

Closed kramaranya closed 2 months ago

kramaranya commented 2 months ago

OCPBUGS-39400

openshift-ci-robot commented 2 months ago

@kramaranya: This pull request references Jira Issue OCPBUGS-39400, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/sriov-network-operator/pull/995): >[OCPBUGS-39400](https://issues.redhat.com/browse/OCPBUGS-39400) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
kramaranya commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@kramaranya: This pull request references Jira Issue OCPBUGS-39400, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-38783](https://issues.redhat.com//browse/OCPBUGS-38783) is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-38783](https://issues.redhat.com//browse/OCPBUGS-38783) targets the "4.18.0" version, which is one of the valid target versions: 4.18.0 * bug has dependents
In response to [this](https://github.com/openshift/sriov-network-operator/pull/995#issuecomment-2326511926): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
zeeke commented 2 months ago

can you please run

make -f Makefile.bundle bundle

and commit related changes? That command will update:

openshift-ci[bot] commented 2 months ago

@kramaranya: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-nfv-hwoffload 769f128eeb414bcc8510f77b665a79a1529e6d6e link false /test e2e-openstack-nfv-hwoffload

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
zeeke commented 2 months ago

/lgtm /approve /label backport-risk-assessed

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kramaranya, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/sriov-network-operator/blob/release-4.17/OWNERS)~~ [zeeke] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
zhaozhanqi commented 2 months ago

/label cherry-pick-approved

openshift-ci-robot commented 2 months ago

@kramaranya: Jira Issue OCPBUGS-39400: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-39400 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/sriov-network-operator/pull/995): >[OCPBUGS-39400](https://issues.redhat.com/browse/OCPBUGS-39400) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-webhook This PR has been included in build sriov-network-webhook-container-v4.17.0-202409040335.p0.g6ffbccd.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-operator This PR has been included in build sriov-network-operator-container-v4.17.0-202409040335.p0.g6ffbccd.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-config-daemon This PR has been included in build sriov-network-config-daemon-container-v4.17.0-202409040335.p0.g6ffbccd.assembly.stream.el9. All builds following this will include this PR.

zeeke commented 2 months ago

/jira backport release-4.15,release-4.16

openshift-ci-robot commented 2 months ago

@zeeke: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges: /cherrypick release-4.15 /cherrypick release-4.16

In response to [this](https://github.com/openshift/sriov-network-operator/pull/995#issuecomment-2328049449): >/jira backport release-4.15,release-4.16 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-cherrypick-robot commented 2 months ago

@openshift-ci-robot: #995 failed to apply on top of branch "release-4.15":

Applying: manifests: set required-scc for openshift workloads
Using index info to reconstruct a base tree...
M   bindata/manifests/daemon/daemonset.yaml
M   bindata/manifests/operator-webhook/server.yaml
M   bindata/manifests/webhook/server.yaml
M   bundle/manifests/sriov-network-operator.clusterserviceversion.yaml
M   config/manager/manager.yaml
M   deploy/operator.yaml
A   deployment/sriov-network-operator-chart/templates/operator.yaml
M   manifests/stable/sriov-network-operator.clusterserviceversion.yaml
Falling back to patching base and 3-way merge...
Auto-merging manifests/stable/sriov-network-operator.clusterserviceversion.yaml
CONFLICT (content): Merge conflict in manifests/stable/sriov-network-operator.clusterserviceversion.yaml
Auto-merging deployment/sriov-network-operator/templates/operator.yaml
Auto-merging deploy/operator.yaml
Auto-merging config/manager/manager.yaml
Auto-merging bundle/manifests/sriov-network-operator.clusterserviceversion.yaml
CONFLICT (content): Merge conflict in bundle/manifests/sriov-network-operator.clusterserviceversion.yaml
Auto-merging bindata/manifests/webhook/server.yaml
Auto-merging bindata/manifests/operator-webhook/server.yaml
Auto-merging bindata/manifests/daemon/daemonset.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 manifests: set required-scc for openshift workloads
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/openshift/sriov-network-operator/pull/995#issuecomment-2328049763): >@zeeke: The following backport issues have been created: >- [OCPBUGS-39502](https://issues.redhat.com//browse/OCPBUGS-39502) for branch release-4.16 >- [OCPBUGS-39503](https://issues.redhat.com//browse/OCPBUGS-39503) for branch release-4.15 > >Queuing cherrypicks to the requested branches to be created after this PR merges: >/cherrypick release-4.15 >/cherrypick release-4.16 > >
> >In response to [this](https://github.com/openshift/sriov-network-operator/pull/995#issuecomment-2328049449): > >>/jira backport release-4.15,release-4.16 > > >Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository. >

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.