Closed PeterYurkovich closed 3 months ago
@PeterYurkovich: all tests passed!
Full PR test history. Your PR dashboard.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jgbernalp, PeterYurkovich
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Resolves #17.
Adds loading status to usePluginAvailable, which is then used to prevent the primary korrel8r query until they have finished running.
Refactored the primary useEffect since it was getting very large with a lot of dependencies. I also tried to use a reducer instead but I found the resulting code to be confusing and that it clashes too much with redux. All of the state could be moved into redux to make everything flow through the same reducer, but we are trying to move off of redux going forward and adding extra project logic to redux seemed like a poor idea with that in mind.
I messed up the rebasing the changes from #20 onto #19, so I'm reopening this with a clean/correct git history.