search

openshift / troubleshooting-panel-console-plugin

Console Plugin to add a troubleshooting side panel to display Korrel8r data
Apache License 2.0
0 stars 7 forks source link

OU-457: Update Netflow URL to add filter query parameter #36

Closed PeterYurkovich closed 3 months ago

PeterYurkovich commented 3 months ago

The Netflow URL's generated from the Korrel8r queries are missing the filter query parameter. The Korrel8r query is only a logql query and can be parsed simply, but before #27 can be merged, the filters => Korrel8r query transformation will need to be looked at, as they have a complex query language built into their filters, much of which Korrel8r doesn't support.

The selected node check added another loop to prevent extra parameters added by a page from stopping a match. For example, if the page adds an additional query parameter of timeRange the logic will now still be able to match and highlight the node

PeterYurkovich commented 3 months ago

/hold

openshift-ci-robot commented 3 months ago

@PeterYurkovich: This pull request references OU-457 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/troubleshooting-panel-console-plugin/pull/36): >The Netflow URL's generated from the Korrel8r queries are missing the filter query parameter. The Korrel8r query is only a logql query and can be parsed simply, but before #27 can be merged, the filters => Korrel8r query transformation will need to be looked at, as they have a complex query language built into their filters, much of which Korrel8r doesn't support. > >The selected node check added another loop to prevent extra parameters added by a page from stopping a match. For example, additional an additional query parameter of `timeRange` will still match now and highlight the node Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Ftroubleshooting-panel-console-plugin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
PeterYurkovich commented 3 months ago

/unhold

openshift-ci-robot commented 3 months ago

@PeterYurkovich: This pull request references OU-457 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/troubleshooting-panel-console-plugin/pull/36): >The Netflow URL's generated from the Korrel8r queries are missing the filter query parameter. The Korrel8r query is only a logql query and can be parsed simply, but before #27 can be merged, the filters => Korrel8r query transformation will need to be looked at, as they have a complex query language built into their filters, much of which Korrel8r doesn't support. > >The selected node check added another loop to prevent extra parameters added by a page from stopping a match. For example, if the page adds an additional query parameter of `timeRange` the logic will now still be able to match and highlight the node Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Ftroubleshooting-panel-console-plugin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jgbernalp commented 3 months ago

/lgtm

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/troubleshooting-panel-console-plugin/blob/main/OWNERS)~~ [PeterYurkovich,jgbernalp] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 3 months ago

@PeterYurkovich: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
PeterYurkovich commented 3 months ago

/cherrypick release-0.1

openshift-cherrypick-robot commented 3 months ago

@PeterYurkovich: new pull request created: #37

In response to [this](https://github.com/openshift/troubleshooting-panel-console-plugin/pull/36#issuecomment-2194727730): >/cherrypick release-0.1 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.