search

openshiftio / openshift.io

Red Hat OpenShift.io is an end-to-end development environment for planning, building and deploying modern applications.
https://openshift.io
97 stars 66 forks source link

Investigate switching to upstream Jenkins image to see if that brings more stability #3861

Open sthaha opened 6 years ago

sthaha commented 6 years ago

It seems a lot more JVM optimisation has gone into Openshift Jenkins. The spike is try using the upstream image to see if it brings about any improvements our current setup.

Planner: https://openshift.io/openshiftio/Openshift_io/plan/detail/294

jaseemabid commented 6 years ago

  1. The fork of the base image openshift/jenkins to fabric8-jenkins/jenkins-openshift-base makes no sense anymore. I'm trying this change here in this PR.

  2. Almost all the builder/slave images in fabric8-images repo is copy pasted BS from upstream.

    1. maven builder should be slave maven, similarly for the other builders as well.
    2. Add oc binary to the master image and get rid of builder clients
    3. fabric8io-images/fabric8-ui-builder should be something that the UI team maintains or slave node
    4. Delete https://github.com/fabric8io/chunky-builder

  3. The indirection to fabric8io/openshift-jenkins-s2i-config is a very bad idea for us. The base image installs several plugins, its probably a much better idea to add a few more plugins there rather than have yet another repo. For example, the s2i-config adds kubernetes:1.3.2 in plugins.txt, while the base image already has kubernetes:1.7.1. We could just delete all of this!

  4. There is huge value in keeping all the images in one repo like the upstream.

jaseemabid commented 6 years ago

Ref https://github.com/fabric8io/openshift-jenkins-s2i-config/pull/176

rupalibehera commented 5 years ago

The PR link is here https://github.com/fabric8io/fabric8-jenkinsfile-library/pull/41

arilivigni commented 5 years ago

https://github.com/fabric8io/openshift-jenkins-s2i-config/pull/215

rupalibehera commented 5 years ago

@arilivigni I am done with the testing and review of the PR, it would be great if you could address them.

hrishin commented 5 years ago

We need to consider the plugins fix while switching to upstream.

The fix is to symlink plugins directory from /var/lib/jenkins/plugins to /opt/openshift/plugins directory in upstream jenkins builder image.

One option for implementing such feature is to enable symlinking with env var switch. If that switch is absent it would not create the symlink in assemble script.

cc: @arilivigni @chmouel