opensim-org / opensim-core

SimTK OpenSim C++ libraries and command-line applications, and Java/Python wrapping.
https://opensim.stanford.edu
Apache License 2.0
758 stars 308 forks source link

PointToPointSpring has no available Outputs #3774

Open aseth1 opened 2 months ago

aseth1 commented 2 months ago

The PointToPointSpring does not implement any Outputs so simple values like, length, force and energy from the spring are unavailable. The potential energy is also wrong. It is set to zero as default implementation by Force, which should either be NaN if not being computed OR is should be pure virtual method of Force so all concrete subclasses have to implement a valid PE.