Use casadi 3.5.5 and revert specification of IPOPT_LIBRARIES on windows

opensim-org / opensim-core

SimTK OpenSim C++ libraries and command-line applications, and Java/Python wrapping.

https://opensim.stanford.edu

Apache License 2.0

758 stars 307 forks source link

Use casadi 3.5.5 and revert specification of IPOPT_LIBRARIES on windows #3799

Closed aymanhab closed 3 weeks ago

aymanhab commented 3 weeks ago

Fixes issue #3798

Brief summary of changes

change tag and spec for libraries on windows, will use ci to check other changes on mac, linux

Testing I've completed

run ci

Looking for feedback on...

CHANGELOG.md (choose one)

no need to update because...
updated.

This change is

aymanhab commented 3 weeks ago

@nickbianco This PR does the reversion and all tests pass on all platforms but I'd like to wait and build a GUI on top of it to see if /what are the downstream problems with installation and RPAPTH settings. In the meantime, you may backport the one file change here locally to continue building/running on windows. Let me know if you run into issues or unexpected behavior.

nickbianco commented 3 weeks ago

Great! I'll try backporting into my local branch on Windows and see how it goes.

aymanhab commented 3 weeks ago

Test failure is bogus, gui built cleanly with this PR.

aymanhab commented 3 weeks ago

Thanks @nickbianco 👍