search

opensocsysarch / CoreGenPortal

OpenSoC System Architect CoreGen Portal Graphical User Interface
http://www.systemarchitect.tech/
Apache License 2.0
1 stars 0 forks source link

Reminder to validate Comm endpoints on backend #63

Closed fconlon closed 4 years ago

fconlon commented 4 years ago

@jleidel Should I move this over to the backend as an issue there? I remember we discussed this when I was doing the comm edit window, but I don't remember what the reasoning was behind it. I should have left a description of what I meant by "validate"

jleidel commented 4 years ago

@jleidel Should I move this over to the backend as an issue there? I remember we discussed this when I was doing the comm edit window, but I don't remember what the reasoning was behind it. I should have left a description of what I meant by "validate"

Not sure what this is in reference to. What do you mean "validate". As long as the InsertEndpoint argument is not NULL or a "CGComm" object, then it should be a valid endpoint.

fconlon commented 4 years ago

Oh I think I remember. We were discussing whether or not nodes such as Ext and Plugin nodes should be allowed as endpoints. I think we decided that Ext and Plugin nodes should not be allowed as endpoints. I think IF nodes might also fall under the "it doesn't make sense as an endpoint" category. I should be able to implement this on the front end, but if we wanted to disallow this behavior it would make more sense on the backend. If the verification is only on the front end then it would still be allowed if the user directly used the CLI.

jleidel commented 4 years ago

Ext and Plugin nodes should be allowed. They may encapsulate cores, caches, etc. However, Inst, PInst and InstFormats should not. I'll open a bug and make the changes

jleidel commented 4 years ago

all the devel tests pass; that bug is now closed

fconlon commented 4 years ago

Sounds good I'll close this issue and create one to implement the invalid field highlighting for endpoints in the UI