search

opensourcecities / montreal

A directory of companies, people, and projects that are Open Source and from Montréal.
https://opensourcecities.github.io/montreal/
The Unlicense
98 stars 31 forks source link

Externalize them to standalone repo #45

Closed khos2ow closed 6 years ago

khos2ow commented 6 years ago

Fixes #43

khos2ow commented 6 years ago

@RichardLitt @ruyadorno this is done, but I'm having second thought to include theme as external git submodule. Because it forces users to know beforehand there will be a submodule to do a git clone --recurse-submodules ... to fork and clone.

On the other hand we should always change the theme directly on its own repo and manually push the changes in standalone commits in the site(s).

What do you think?

khos2ow commented 6 years ago

and the repo in question is this: https://github.com/opensourcecities/osc-theme/tree/master

RichardLitt commented 6 years ago

I think it's only a problem if it's undocumented. Add a note to the README, and we're good.

Users simply adding content should never have to download the submodule, though. Is this a requirement, at the moment?

khos2ow commented 6 years ago

No, not a requirement, but if they want to run hugo server locally then it works, but nothing will be shown in browser. I agree about documenting though.

ruyadorno commented 6 years ago

🎉