opensrp / fhircore

FHIR Core / OpenSRP 2 is a Kotlin application for delivering offline-capable, mobile-first healthcare project implementations from local community to national and international scale using FHIR and WHO Smart Guidelines on Android.
https://opensrp.io
Apache License 2.0
58 stars 59 forks source link

Added configurations for the spacer and empty list text in the list view #3591

Closed Aleem92 closed 1 week ago

Aleem92 commented 3 weeks ago

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Engineer Checklist

Code Reviewer Checklist

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 27.4%. Comparing base (5a9981e) to head (2b9165e). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...gister/fhircore/quest/ui/shared/components/List.kt 0.0% 10 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/opensrp/fhircore/pull/3591/graphs/tree.svg?width=650&height=150&src=pr&token=IJUTHZUGGH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp)](https://app.codecov.io/gh/opensrp/fhircore/pull/3591?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) ```diff @@ Coverage Diff @@ ## main #3591 +/- ## ========================================= - Coverage 27.4% 27.4% -0.1% Complexity 785 785 ========================================= Files 282 282 Lines 14677 14683 +6 Branches 2630 2634 +4 ========================================= + Hits 4023 4024 +1 - Misses 10108 10114 +6 + Partials 546 545 -1 ``` | [Flag](https://app.codecov.io/gh/opensrp/fhircore/pull/3591/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | Coverage Δ | | |---|---|---| | [engine](https://app.codecov.io/gh/opensrp/fhircore/pull/3591/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `63.8% <ø> (ø)` | | | [geowidget](https://app.codecov.io/gh/opensrp/fhircore/pull/3591/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `16.0% <ø> (ø)` | | | [quest](https://app.codecov.io/gh/opensrp/fhircore/pull/3591/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `5.9% <0.0%> (+<0.1%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/opensrp/fhircore/pull/3591?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | Coverage Δ | | |---|---|---| | [...ircore/engine/configuration/view/ListProperties.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3591?src=pr&el=tree&filepath=android%2Fengine%2Fsrc%2Fmain%2Fjava%2Forg%2Fsmartregister%2Ffhircore%2Fengine%2Fconfiguration%2Fview%2FListProperties.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9lbmdpbmUvc3JjL21haW4vamF2YS9vcmcvc21hcnRyZWdpc3Rlci9maGlyY29yZS9lbmdpbmUvY29uZmlndXJhdGlvbi92aWV3L0xpc3RQcm9wZXJ0aWVzLmt0) | `92.3% <ø> (ø)` | | | [...gister/fhircore/quest/ui/shared/components/List.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3591?src=pr&el=tree&filepath=android%2Fquest%2Fsrc%2Fmain%2Fjava%2Forg%2Fsmartregister%2Ffhircore%2Fquest%2Fui%2Fshared%2Fcomponents%2FList.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9xdWVzdC9zcmMvbWFpbi9qYXZhL29yZy9zbWFydHJlZ2lzdGVyL2ZoaXJjb3JlL3F1ZXN0L3VpL3NoYXJlZC9jb21wb25lbnRzL0xpc3Qua3Q=) | `0.0% <0.0%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/opensrp/fhircore/pull/3591/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp)