opensrp / fhircore

FHIR Core / OpenSRP 2 is a Kotlin application for delivering offline-capable, mobile-first healthcare project implementations from local community to national and international scale using FHIR and WHO Smart Guidelines on Android.
https://opensrp.io
Apache License 2.0
58 stars 59 forks source link

Implement Save draft MVP functionality #3596

Closed Rkareko closed 2 weeks ago

Rkareko commented 3 weeks ago

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3541

Engineer Checklist

Code Reviewer Checklist

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 20.00000% with 32 lines in your changes missing coverage. Please review.

Project coverage is 27.1%. Comparing base (6fc15b0) to head (b86ac44). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...e/quest/ui/questionnaire/QuestionnaireViewModel.kt 4.3% 22 Missing :warning:
...re/quest/ui/questionnaire/QuestionnaireActivity.kt 0.0% 6 Missing :warning:
...re/engine/util/extension/QuestionnaireExtension.kt 20.0% 3 Missing and 1 partial :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/opensrp/fhircore/pull/3596/graphs/tree.svg?width=650&height=150&src=pr&token=IJUTHZUGGH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp)](https://app.codecov.io/gh/opensrp/fhircore/pull/3596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) ```diff @@ Coverage Diff @@ ## main #3596 +/- ## ========================================= - Coverage 27.1% 27.1% -0.1% Complexity 775 775 ========================================= Files 279 280 +1 Lines 14563 14606 +43 Branches 2608 2617 +9 ========================================= + Hits 3957 3967 +10 - Misses 10065 10097 +32 - Partials 541 542 +1 ``` | [Flag](https://app.codecov.io/gh/opensrp/fhircore/pull/3596/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | Coverage Δ | | |---|---|---| | [engine](https://app.codecov.io/gh/opensrp/fhircore/pull/3596/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `63.7% <63.6%> (-0.1%)` | :arrow_down: | | [geowidget](https://app.codecov.io/gh/opensrp/fhircore/pull/3596/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `16.0% <ø> (ø)` | | | [quest](https://app.codecov.io/gh/opensrp/fhircore/pull/3596/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `5.7% <3.4%> (+<0.1%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/opensrp/fhircore/pull/3596?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | Coverage Δ | | |---|---|---| | [...tregister/fhircore/engine/ui/base/AlertDialogue.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3596?src=pr&el=tree&filepath=android%2Fengine%2Fsrc%2Fmain%2Fjava%2Forg%2Fsmartregister%2Ffhircore%2Fengine%2Fui%2Fbase%2FAlertDialogue.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9lbmdpbmUvc3JjL21haW4vamF2YS9vcmcvc21hcnRyZWdpc3Rlci9maGlyY29yZS9lbmdpbmUvdWkvYmFzZS9BbGVydERpYWxvZ3VlLmt0) | `79.6% <100.0%> (+0.9%)` | :arrow_up: | | [...re/engine/util/extension/QuestionnaireExtension.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3596?src=pr&el=tree&filepath=android%2Fengine%2Fsrc%2Fmain%2Fjava%2Forg%2Fsmartregister%2Ffhircore%2Fengine%2Futil%2Fextension%2FQuestionnaireExtension.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9lbmdpbmUvc3JjL21haW4vamF2YS9vcmcvc21hcnRyZWdpc3Rlci9maGlyY29yZS9lbmdpbmUvdXRpbC9leHRlbnNpb24vUXVlc3Rpb25uYWlyZUV4dGVuc2lvbi5rdA==) | `55.3% <20.0%> (-1.6%)` | :arrow_down: | | [...re/quest/ui/questionnaire/QuestionnaireActivity.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3596?src=pr&el=tree&filepath=android%2Fquest%2Fsrc%2Fmain%2Fjava%2Forg%2Fsmartregister%2Ffhircore%2Fquest%2Fui%2Fquestionnaire%2FQuestionnaireActivity.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9xdWVzdC9zcmMvbWFpbi9qYXZhL29yZy9zbWFydHJlZ2lzdGVyL2ZoaXJjb3JlL3F1ZXN0L3VpL3F1ZXN0aW9ubmFpcmUvUXVlc3Rpb25uYWlyZUFjdGl2aXR5Lmt0) | `3.7% <0.0%> (-0.1%)` | :arrow_down: | | [...e/quest/ui/questionnaire/QuestionnaireViewModel.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3596?src=pr&el=tree&filepath=android%2Fquest%2Fsrc%2Fmain%2Fjava%2Forg%2Fsmartregister%2Ffhircore%2Fquest%2Fui%2Fquestionnaire%2FQuestionnaireViewModel.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9xdWVzdC9zcmMvbWFpbi9qYXZhL29yZy9zbWFydHJlZ2lzdGVyL2ZoaXJjb3JlL3F1ZXN0L3VpL3F1ZXN0aW9ubmFpcmUvUXVlc3Rpb25uYWlyZVZpZXdNb2RlbC5rdA==) | `3.3% <4.3%> (+<0.1%)` | :arrow_up: |
Rkareko commented 2 weeks ago

Quick feedback

1. Edit not working in the PR

2. The questionnaire is not dismissed once the user makes the selection

3. Add docs to accompany this PR
   CC @Rkareko

these have been addressed