search

opensrp / miecd

0 stars 0 forks source link

14 compartments overview #27

Closed machariamuguku closed 3 years ago

machariamuguku commented 3 years ago

Fixes #14

  1. If age range starts at 0 and ends at x, both age 0 and age x are within range. For example both 0 and 2 are valid for age range 0-2
  2. If age range starts at y, such that y > 0, and ends at z, y is exclusive (not within range) but z is within range. For example for age range 2-5, 2 is not within range but 5 is. i.e, anything above 2 is within range but 2 itself is not
machariamuguku commented 3 years ago

@ageryck confirm that the age's to be displayed on compartments for nutrition are for age ranges 0-2 and 2-5 and not for ages 0-2 and 0-5

ageryck commented 3 years ago

@ageryck confirm that the age's to be displayed on compartments for nutrition are for age ranges 0-2 and 2-5 and not for ages 0-2 and 0-5

@machariamuguku document states under 2 and under 5 - this means this 0-2 and 0-5, under 2 is a subset of under 5. Following for further clarification still.

machariamuguku commented 3 years ago

@machariamuguku document states under 2 and under 5 - this means this 0-2 and 0-5, under 2 is a subset of under 5. Following for further clarification still.

@ageryck also follow up on age calculations and whether months matter. I.e whether 2 years and 2 months should be in range 0-2 or 2-5

machariamuguku commented 3 years ago

@ageryck According to the technical documentation, the child range covered for the nutrition module is 0-5 years, this means that the totals rows added as per #14 is similar to the 0-5 range. It doesn't make sense to have two similar metrics. I propose we keep ranges 0-2, 2-5 and total (0-5), which is the current state of this PR. About age calculations, this PR interprets age 2 years and 2 months as in range 2-5 and not 0-2. I propose this be merged as is

machariamuguku commented 3 years ago

@ageryck disregard previous comment, I've revisited the change request and the technical documentation and discovered the change requested is totals on compartment headers and not a new totals row. I've also reverted the filters to 0-2 and 0-5.