Closed owais-vd closed 2 years ago
@owais-vd Can you provide a description on what the issue was and the fix?
@owais-vd Can you provide a description on what the issue was and the fix?
on the application load, SyncTaskWithClientEventsServiceJob
job schedule immediately and blocked the processClient
method. i made the schedule with delay to prevent the processClient
method from being blocked.
Hi @owais-vd
The boolean toReschedule = TimeUnit.MINUTES.toMillis(start) < TimeUnit.MINUTES.toMillis(15);
change makes sense.
Did you try testing a fix with scheduling periodically instead prior to writing the custom implementation?
Hi @owais-vd The
boolean toReschedule = TimeUnit.MINUTES.toMillis(start) < TimeUnit.MINUTES.toMillis(15);
change makes sense. Did you try testing a fix with scheduling periodically instead prior to writing the custom implementation?
Hi, i didn't check with default scheduling periodically method. I'll check and confirm
The branch cannot currently be merged with unverified commits in it's history and will require a re-write or force-merge
@allan-on Kindly approve again. The difference is that I removed 2 unsigned commits by Owais. The following are the commits
commit 30a9915b1b5eec583012d4d17e25236ca55c2e36
Author: owais <syedowaisali@users.noreply.github.com>
Date: Fri Jul 29 11:47:15 2022 +0500
Revert "Merge branch 'master' into issue-2077"
This reverts commit 7a9a6556d2432452d5ab7f1314be566994966774.
commit eaa979ed0185785818f5fc4e7e6c513f996ce26c
Author: owais <syedowaisali@users.noreply.github.com>
Date: Fri Jul 29 15:24:49 2022 +0500
trigger build
close https://github.com/opensrp/opensrp-client-chw/issues/2077, https://github.com/opensrp/opensrp-client-chw/issues/2078