search

openssi / peer-did-method-spec

A spec for the did:peer DID method.
https://dhh1128.github.io/peer-did-method-spec/index.html
Apache License 2.0
30 stars 17 forks source link

Correct multibase character #59

Closed Oskar-van-Deventer closed 5 years ago

Oskar-van-Deventer commented 5 years ago

Signed-off-by: Oskar van Deventer 46109652+Oskar-van-Deventer@users.noreply.github.com The example uses base16 (lower case), while the multibase character is "F" (upper case, i.e. base16upper). It is proposed to resolve this inconsistency by changing the multibase character into "f" (lower case, i.e. base16).

dhh1128 commented 5 years ago

Oskar, I ended up abandoning multibase because I decided the flexibility of multibase was not worth the encoding cost. See https://github.com/openssi/peer-did-method-spec/issues/62. Are you okay with closing this PR?

Oskar-van-Deventer commented 5 years ago

Oskar, I ended up abandoning multibase because I decided the flexibility of multibase was not worth the encoding cost. See #62. Are you okay with closing this PR?

Daniel, Good solution. Yes, please close #59. Oskar

Oskar-van-Deventer commented 5 years ago

Closed, as Daniel found a better solution.

Oskar