search

openstack-charmers / zaza

A Python3-only functional test framework for Charms
Apache License 2.0
10 stars 46 forks source link

utilities: Convert juju base into Ubuntu series #622

Closed fnordahl closed 6 months ago

fnordahl commented 9 months ago

Juju 3.x replaced the series status key with a base key that consists of Distribution type and version number.

To avoid maintenance burden we add a Launchpad module that implements functions to look up available Ubuntu series data.

Update the get_machine_series helper function to determine Ubuntu series from base when no series key is available.

codecov[bot] commented 9 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (00af63d) 89.14% compared to head (76dfea8) 89.15%.

Files Patch % Lines
zaza/utilities/juju.py 86.66% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## libjuju-3.1 #622 +/- ## =============================================== + Coverage 89.14% 89.15% +0.01% =============================================== Files 44 45 +1 Lines 4689 4713 +24 =============================================== + Hits 4180 4202 +22 - Misses 509 511 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

freyes commented 6 months ago

I will close this PR since this patch found its way into master as part of the juju-3.x support.

https://github.com/openstack-charmers/zaza/commit/dfbdbec44f6dd383393dcd3a07b563fdba48503b