openstenoproject / plover

Open source stenotype engine
http://opensteno.org/plover
GNU General Public License v2.0
2.35k stars 279 forks source link

Some extra keys are being treated as steno keys #1289

Open JorWat25 opened 3 years ago

JorWat25 commented 3 years ago

Describe the bug

When Plover is active on my laptop, the mute and volume down keys become W and A keys respectively. According one website, they are keys <181> and <182>.

To Reproduce

Steps to reproduce the behavior:

  1. Activate Plover
  2. Press the mute or volume down keys
  3. See W or A

Expected behavior

Either nothing should happen, or the keys should do their usual function.

Operating system

Hardware

The laptop is an Lenovo Ideapad.

I should note it is only the laptop keys that do this. An external keyboard, also with volume keys apparently with the same code numbers, works normally when Plover is activated.

user202729 commented 3 years ago

Plover reads scan code rather than virtual key code (vkCode).

I don't know what was the purpose (does it make a difference with Dvorak keyboards? Or something else?), given that Plover also use vkCode to determine if a key is a modifier key (PASSTHROUGH_KEYS).

A possible fix is: (moved to pull request)

This fix has the side effect that the / and Return keys on the number pad will not be mappable with this change. (not tested)

Or is it better to use vkCode for both?

khonkhortisan commented 1 year ago

I have the exact same problem on a 💻Dell Latitude E6410: volume down is a, volume up does nothing, mute is with, volume down+mute is was. Those three buttons' normal behaviour is blocked while plover is enabled; the volume doesn't change. These are the buttons autohotkey sees pressed when plover is disabled and I press down up mute.

VK  SC  Type    Up/Dn   Elapsed Key     Window
-------------------------------------------------------------------------------------------------------------
AE  12E     d   1.81    Volume_Down     
AE  12E     u   0.08    Volume_Down     
AF  130     d   0.48    Volume_Up       
AF  130     u   0.14    Volume_Up       
AD  120     d   0.50    Volume_Mute     
AD  120     u   0.17    Volume_Mute

These are the buttons autohotkey sees pressed when plover is enabled and I press down up mute and it types awith

VK  SC  Type    Up/Dn   Elapsed Key     Window
-------------------------------------------------------------------------------------------------------------
AE  12E     d   2.03    Volume_Down     
AE  12E     u   0.05    Volume_Down     
20  039 #   d   0.03    Space           
20  039 #   u   0.00    Space           
41  01E #   d   0.00    a               
41  01E #   u   0.00    a               
AF  130     d   0.34    Volume_Up       
AF  130     u   0.11    Volume_Up       
AD  120     d   0.38    Volume_Mute     
AD  120     u   0.16    Volume_Mute     
57  011 a   d   0.02    w               
57  011 a   u   0.00    w               
49  017 a   d   0.01    i               
49  017 a   u   0.00    i               
54  014 h   d   0.00    t               
54  014 a   u   0.00    t               
48  023 a   d   0.00    h               
48  023 a   u   0.00    h