openstreetmap / leaflet-osm

OpenStreetMap plugin for Leaflet
Other
111 stars 32 forks source link

Selected multipolygons are not rendered correctly filled #32

Open Sinuhe20 opened 2 years ago

Sinuhe20 commented 2 years ago

copied from https://github.com/openstreetmap/openstreetmap-website/issues/3600 :

URL

https://www.openstreetmap.org/relation/14358790

How to reproduce the issue?

Expected behavior

Selected multipolygons should be filled correctly (without the inner holes). Selected multipolygons should be rendered as true multipolygons.

Or in other terms: inner holes should never be filled and the outer areas always (no matter what tags are set).

Actual behavior

Selected multipolygons are not filled correctly or are not really rendered as multipolygons. It looks like each member (inner or outer line) is rendered individually.

Links and screenshots illustrating the problem

Two temple sites with almost the same attributes, the one as way (Luxor) is filled, the other as multipolygon (Karnak) not:

Overpass turbo renders multipolygons correctly filled:

https://overpass-turbo.eu/s/1kaj

And it seems not be related to the complexity of the outline:

https://www.openstreetmap.org/relation/2017780 (also not filled)

Another example, which works wrong in the other direction:

https://www.openstreetmap.org/relation/6713255

A multipolygon, where all areas, even the inner holes are filled. I think this can be related to the landuse property set or area=yes. Looks like all members are rendered individually and only their tags are considered, but not that of the multipolygon. In my opinion selected multipolygons should all be rendered in the same way with the inner holes empty and the rest filled, no matter which tags are set.

Screenshot(s) or anything else?

No response