search

openstudiocoalition / OpenStudioApplication

The OpenStudio Application is a fully featured graphical interface to OpenStudio models including envelope, loads, schedules, and HVAC.
https://openstudiocoalition.org
Other
137 stars 25 forks source link

Add early failure for too old macOS, XCode or target macOS version #678

Closed mduvanel closed 9 months ago

mduvanel commented 10 months ago

Qt6 mandates to target macOS 11.0 or greater, but also to have XCode 13 or greater to compile. See this explicit error from the lrelease utility using XCode 12 on macOS 10.15.7:

FAILED: translations/OpenStudioApp_de.qm /.../OpenStudioApplication/build/translations/OpenStudioApp_de.qm
cd /.../OpenStudioApplication/build/translations && /.../Qt/6.6.1/macos/bin/lrelease /.../OpenStudioApplication/translations/OpenStudioApp_de.ts -qm /...OpenStudioApplication/build/translations/OpenStudioApp_de.qm
Sorry, "lrelease" cannot be run on this version of macOS. Qt requires macOS 11.0.0 or later, you have macOS 10.15.7.

This PR adds early checks for these hard requirements.

github-actions[bot] commented 10 months ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

mduvanel commented 10 months ago

I have read the CLA Document and I hereby sign the CLA

macumber commented 9 months ago

I will merge once CI completes, thanks!

mduvanel commented 9 months ago

I will merge once CI completes, thanks!

Thank you for the quick turnaround!