Fix issues with MeasureManager - Githubissues

openstudiocoalition / OpenStudioApplication

The OpenStudio Application is a fully featured graphical interface to OpenStudio models including envelope, loads, schedules, and HVAC.

https://openstudiocoalition.org

Other

137 stars 25 forks source link

Fix issues with MeasureManager #720

Closed macumber closed 3 months ago

macumber commented 4 months ago

[x] Add loading tab to discourage selecting another measure which arguments for first measure are being computed (this can take a long time in failure case).
[x] Catch all std::exceptions instead of just RubyExceptions which prevents crash. Fixes #656
[x] Display more informative message in case of "Failed to Infer Measure Name". Related to #716
[x] Fix "Do you want to reset Measure Manager settings" #717
[x] Add "Example->Shoebox Model" based on https://github.com/openstudiocoalition/openstudio-coalition-measures/tree/main/models/ShoeboxExample
[x] Remove auto update of openstudio_results measure for new models, fixes #722
[x] Delete measure dir when removing measure step, fixes #115
[x] Fixes crash on startup #687
[x] Show Python/Ruby measure badge on measures in the workflow, fixes #670
[x] Update arguments to update_measures, fixes #620

macumber commented 4 months ago

@jmarrec when updating a model with the old results measure, we probably need to swap the new one out, currently there is a crash due to this. The exception is caught in this branch now at least. However, there are going to be many measures that might need to be updated. So maybe it's best to not update the results measure, we can just show the errors and make users delete/replace measures themselves. This is going to be something we need to address in the release notes.

macumber commented 4 months ago

@jmarrec if you have a chance to review this that would be good, the PR is not too big if you ignore src/openstudio_app/Resources/ which is just copies of measures from BCL

jmarrec commented 4 months ago

I'd probably have liked if the "Example > Shoebox Model" was isolated into its own PR.

macumber commented 4 months ago

I'd probably have liked if the "Example > Shoebox Model" was isolated into its own PR.

Agreed, sorry I was in a rush, I can move it to a new PR if you'd like

FYI, I did merge https://github.com/openstudiocoalition/openstudio-coalition-measures/pull/3 and release https://github.com/openstudiocoalition/openstudio-coalition-measures/releases/tag/v1.8.0 to support this

macumber commented 4 months ago

Ping @jmarrec, do you want to give this a review? If not, I think we could merge and push out an RC1. What do you think?

jmarrec commented 4 months ago

Ping @jmarrec, do you want to give this a review? If not, I think we could merge and push out an RC1. What do you think?

An RC1 for 1.8.0? I'd like to see if we can get an updated CLI with https://github.com/NREL/OpenStudio/issues/5230 fixed first

macumber commented 4 months ago

I don't think we need an updated 1.8.0 package. After I tested, the main issue was with the OpenStudio Results measure which gets downloaded and added to each model by default at startup. I fixed that in the 1.7.2 release. The other BCL menus have some filtering built into them, I think I have handled all the needed cases in this PR such that we don't have to have an update to OS SDK.