search

opentable / wiremock-body-transformer

Wiremock Body Transformer Extension
Apache License 2.0
65 stars 42 forks source link

Added parsing logic for the key=value body requests #11

Closed KRoLer closed 8 years ago

KRoLer commented 8 years ago

Added parsing logic for the requests of type application/x-www-form-urlencoded with the key=value body string.

I didn't find another way to reach them except to extend an existing logic. If you think it will be useful I can update documentation for this feature. If you know another way how to do it I'll be also glad to hear it.

tranhungt commented 8 years ago

@KRoLer Thanks for this. I think this could be useful in extending the applicability of this transformer, since we should support multiple request body types. I can look more into the wiremock library to see if there are any other possible solutions. We should go ahead and add the documentation to this PR.

tranhungt commented 8 years ago

@KRoLer Sorry for the late review. I like this PR. Could you check the comments, fix the conflict, and add some documentation? I can merge asap.

Thanks.

KRoLer commented 8 years ago

@tranhungt, thanks for the review. I've fixed issue for the case when it has only parameter name and commits it; I've not planned to change my PR. If you accept this solution at all, I'll refactor and prettify code before the merge. :-)

KRoLer commented 8 years ago

Hey, @tranhungt,

I've updated my PR. Now it had an actual code version, fixed test issues and added all needed logic, including UTF-8 values decoding.

tranhungt commented 8 years ago

Thanks @KRoLer this looks great! I'll check it out tomorrow morning.