search

opentargets / issues

Issue tracker for Open Targets Platform and Open Targets Genetics Portal
https://platform.opentargets.org https://genetics.opentargets.org
Apache License 2.0
12 stars 2 forks source link

Resolve protvista structure z-index issue #1723

Open d0choa opened 3 years ago

d0choa commented 3 years ago

Problem applies to us, but also Uniprot site...

Screenshot 2021-08-18 at 16 29 57 Screenshot 2021-08-18 at 16 29 10
d0choa commented 2 years ago

They seem to have resolved the issue in the uniprot beta

Screenshot 2021-12-09 at 12 05 32

But they are issue the isolated component not the whole Protvista

LucaFumis commented 1 year ago

Just had a quick look at this - problem still there, but not as prominent / noticeable. We currently use protvista-uniprot 2.8.8. When the bug was reported, it was probably version 2.7.4. I believe the layout of the widget in 2.8.8 is slightly different: the 3d model sits more to the right. As a result, there is a very minor overlap with our navigation bar, which only occurs for window widths in the range of around 960-990 pixels.

A newer 2.8.9 version has just been released, however this seemed to cause some issues when I tried installing it.

LucaFumis commented 1 year ago

Recently tested a newer version of protvista-uniprot and the issue is still present.

I believe the layout of the widget in 2.8.8 is slightly different: the 3d model sits more to the right. As a result, there is a very minor overlap with our navigation bar, which only occurs for window widths in the range of around 960-990 pixels.

Actually it appears the 3d model shows a "Model confidence" legend (that changes the layout) but only for certain genes - see for example ADORA3 vs BRAF.

The bug is caused by the element <protvista-structure> setting the z-index to 40000:

.protvista-uniprot-structure__structure protvista-structure {
    z-index: 40000;
    width: 100%;
    flex: 4;
}

We could try to reset that (or work around it in some other way).

LucaFumis commented 11 months ago

The Protvista table also has the same issue, as the table head is set to a specific z-index

otvista-datatable table th {
    // ...
    z-index: 400;
}

However, since we removed the left-hand side navigation on the OT Platform, the issue no longer exists. It could become obvious again if for example we had a sticky top search/nav bar.

LucaFumis commented 11 months ago

Re-assigning to @carcruz for the @opentargets/fe-team Might not need action

prashantuniyal02 commented 1 month ago

Hey @gjmcn , does this issue still exist with the updated prot-vista?