opentargets / issues

Issue tracker for Open Targets Platform and Open Targets Genetics Portal
https://platform.opentargets.org https://genetics.opentargets.org
Apache License 2.0
12 stars 2 forks source link

Change hashing strategy for StudyLocusId generation in StudyLocus object #3448

Closed project-defiant closed 2 months ago

project-defiant commented 2 months ago

As a developer I want change the hashing strategy to md5 when calculating StudyLocusId because current implementation requires casting big integer to a string to be ingested by the platform.

Background

This task is required due to the fact we do not create proper hashes within StudyLocusId field of StudyLocus object.

Tasks

Acceptance tests

project-defiant commented 2 months ago

@DSuveges FYI

d0choa commented 2 months ago

Reassigning to @vivienho based on discussions with @DSuveges

@DSuveges the ticket might not have the right context, so @vivienho might need some extra guidelines

The change in the hashes will break all the data compatibility, so @project-defiant, you might want to keep an eye on it

Related to https://github.com/opentargets/issues/issues/3535

project-defiant commented 2 months ago

@d0choa we should not merge this unless we are sure we can reparse all indices for credible sets, or recalculate entire study_locus

DSuveges commented 2 months ago

I think we'll re-calculate the entire dataset a few time till the release.

d0choa commented 2 months ago

It's never a good time to make this change. But it will get a lot worse soon