search

opentelecoms-org / jsmpp

SMPP implemented in Java
Apache License 2.0
230 stars 160 forks source link

Fixed #163. Fixed a copy paste error in OptionalParameter and exception handling in SMPPServerSession. #196

Closed sana167 closed 8 months ago

sana167 commented 1 year ago

OptionalParameter.java: User_response_code uses USER_MESSAGE_REFERENCE tag. Seems to be missed while copy paste from previous User_message_reference. SMPPServerSession.java: When a ProcessRequestException is thrown by the client application, it should not be wrapped in a new ProcessRequestException. This seems to be done for processSubmitSm and processDataSm but missed for other process() methods.

pmoerenhout commented 8 months ago

@sana167 Thanks for spotting this error