opentok / OpenTok-PHP-SDK

OpenTok PHP Server SDK

https://tokbox.com/developer/sdks/php/

MIT License

139 stars 146 forks source link

Fix/validate classlist fix #320

Closed SecondeJK closed 2 years ago

SecondeJK commented 2 years ago

Small logic change to fix how the Validator works

Description

As detailed in this SO answer: https://stackoverflow.com/questions/173400/how-to-check-if-php-array-is-associative-or-sequential/173479#173479

And credited from this GH issue: #270

How Has This Been Tested?

Test suite passes

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

codecov[bot] commented 2 years ago

Codecov Report

Merging #320 (e642c5e) into dev (2490450) will decrease coverage by 0.0%. The diff coverage is 75.0%.

Impacted Files	Coverage Δ
src/OpenTok/Util/Validators.php	`71.9% <66.6%> (-0.3%)`	:arrow_down:
src/OpenTok/Util/Client.php	`74.7% <100.0%> (ø)`