search

opentok / Opentok-Python-SDK

OpenTok Python SDK
https://tokbox.com/developer/sdks/python/
MIT License
73 stars 82 forks source link

XML API Deprecated Being Used in Python SDK #203

Open ethauber opened 2 years ago

ethauber commented 2 years ago

The Tokbox developer docs say that the XML API is deprecated here https://tokbox.com/developer/rest/#:~:text=This%20XML%20version%20of%20the%20API%20call%20is%20deprecated Yet, I see it is still being used in the Python SDK here https://github.com/opentok/Opentok-Python-SDK/blob/v3.2.0/opentok/opentok.py#L417 as the default. When will this be fixed? Is there something that I may have misunderstood?

ethauber commented 2 years ago

I also submitted this to customer support. There was a question on if there is a specific issue.

Could you please let me know if you are facing any specific issue regarding Python SDK?

The specific issues are that we do not want to build on top of Vonage's deprecated API and that there are known vulnerabilities with XML APIs. Also, we will have to redo, or implement twice, our current tests since the mocker that we use with requests has to supply XML responses instead of the usual JSON responses.

maxkahan commented 1 year ago

Hi @ethauber it appears the create_session method has not been updated for a couple of years. It could probably use an update, will discuss this internally and feed back to you.