search

opentracing-contrib / java-jaxrs

OpenTracing Java JAX-RS instrumentation
Apache License 2.0
37 stars 33 forks source link

String comparison using equals #145

Closed jasondlee closed 3 years ago

jasondlee commented 3 years ago

I could be missing something subtle, but this looks like a bug (String comparison using == instead of .equals() ).

https://github.com/opentracing-contrib/java-jaxrs/blob/196c72d484691f615bb354ca8e46b9b305726283/opentracing-jaxrs2/src/main/java/io/opentracing/contrib/jaxrs2/server/OperationNameProvider.java#L93

rishi-lgtm commented 3 years ago

I could be missing something subtle, but this looks like a bug (String comparison using == instead of .equals() ).

https://github.com/opentracing-contrib/java-jaxrs/blob/196c72d484691f615bb354ca8e46b9b305726283/opentracing-jaxrs2/src/main/java/io/opentracing/contrib/jaxrs2/server/OperationNameProvider.java#L93

what if m.getName is Null. [.equals] will throw a NPE .

pavolloffay commented 3 years ago

would you like to submit a fix?

rishi-lgtm commented 3 years ago

would you like to submit a fix?

Can you please assign to me?

rishi-lgtm commented 3 years ago

@pavolloffay Can u provide me access. i am getting below error while pusing. remote: Permission to opentracing-contrib/java-jaxrs.git denied to rishi-lgtm. fatal: unable to access 'https://github.com/opentracing-contrib/java-jaxrs.git/': The requested URL returned error: 403

pavolloffay commented 3 years ago

The repository is public you should be able to fork it and submit a PR from your fork.

rishi-lgtm commented 3 years ago

Have raised a PR https://github.com/opentracing-contrib/java-jaxrs/pull/146

pavolloffay commented 3 years ago

Done in #146