opentracing-contrib / java-kafka-client

OpenTracing Instrumentation for Apache Kafka Client
Apache License 2.0
125 stars 64 forks source link

Add public support for SpanDecorators in `buildAndFinishChildSpan` and `buildAndInjectSpan` #78

Closed mviamari closed 4 years ago

mviamari commented 4 years ago

Changes the visibility for buildAndFinishChildSpan and buildAndInjectSpan to be public for all methods so that a custom list of SpanDecorators can be provided. This is necessary when customizing interceptors. An example would be custom tracing interceptors for use with kafka connect.

There are several ways to solve this, including adding support for SpanDecorators to the tracing interceptor classes (which has it's own complications because of how Interceptors are instantiated and configured). I could not think of a reason why just those function signatures would not be public, given that there are multiple variants that already are public.

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 240


Totals Coverage Status
Change from base Build 239: 0.0%
Covered Lines: 274
Relevant Lines: 414

💛 - Coveralls