search

opentracing-contrib / java-spring-web

OpenTracing Spring Web instrumentation
Apache License 2.0
107 stars 59 forks source link

Bump to OpenTracing 0.33 #116

Closed geoand closed 4 years ago

geoand commented 5 years ago

Resolves #121

geoand commented 5 years ago

Opened the PR as a draft, because one of the dependencies has not yet hit Maven Central

geoand commented 5 years ago

io.opentacing.contrib:opentracing-spring-tracer-configuration-starter:0.3.0 still not on Maven Central so I did a new 0.3.1 release and will update this PR once it's ready

geoand commented 5 years ago

@pavolloffay any idea why the releases of io.opentacing.contrib:opentracing-spring-tracer-configuration-starter seem to not be making it to Maven Central?

pavolloffay commented 5 years ago

First I check the builds https://travis-ci.org/opentracing-contrib/java-spring-tracer-configuration/builds. It seems that sync to central failed https://travis-ci.org/opentracing-contrib/java-spring-tracer-configuration/builds/576688050#L880

Then I check binray https://bintray.com/opentracing/maven/opentracing-spring-default-tracer-configuration 0.3.1 is there.

I think you have these options:

  1. sync to maven central via binray UI
  2. restart the whole process - remove release from binray and restart failed travis job
  3. push next release tag to trigger a new release

If you don't have access to binray let me know I will add you.

geoand commented 5 years ago

Thanks @pavolloffay.

I guess that you already performed the sync from the Bintray UI? I seem to have access, so I'll do it next time

pavolloffay commented 5 years ago

I haven't synced it.

geoand commented 5 years ago

OK, I'm not sure what I am supposed to use for User token key and User token password when using on the Maven Central "tab"

pavolloffay commented 5 years ago

sonatype user:pass

geoand commented 5 years ago

Got it, thanks!

mattbroekhuis commented 5 years ago

This builds locally. Can we get it released? I am guessing just re-triggering the build would do it?

geoand commented 5 years ago

I restarted it, lets see what happens

geoand commented 5 years ago

@pavolloffay Can you please review when you have some time?

ttddyy commented 4 years ago

Hi, I am waiting this version bump to happen as well.

What is the plan here? Are you going to release new version soon? When would it be?

We are in need for this change, and if it doesn't happen, we need to re-evaluate our upgrades with opentracing API v0.33.

So, appreciate merge and release would happen soon.

Thanks,

geoand commented 4 years ago

I will merge and do a 3.x release on Monday unless you have any objections @pavolloffay

pavolloffay commented 4 years ago

+1 go ahead

geoand commented 4 years ago

I just released version 3.0.0. It should hopefully be in Maven Central in less than 24h

ttddyy commented 4 years ago

@geoand @pavolloffay Thanks!!