Span not finished when subscription is cancelled

[NHebrard]

Hello!

In the TracingOperator component is there any good reason the not finish the span when the wrapped source has been canceled?

I would change

class TracingOperator extends MonoOperator<Void, Void> {

    @Override
    public void subscribe(final CoreSubscriber<? super Void> subscriber) {
        // ...
        try (final Scope scope = tracer.scopeManager().activate(span)) {
            exchange.getAttributes().put(TracingWebFilter.SERVER_SPAN_CONTEXT, span.context());
            source.subscribe(new TracingSubscriber(subscriber, exchange, context, span, spanDecorators));
        }
    }

To

class TracingOperator extends MonoOperator<Void, Void> {

    @Override
    public void subscribe(final CoreSubscriber<? super Void> subscriber) {
        // ...
        try (final Scope scope = tracer.scopeManager().activate(span)) {
            exchange.getAttributes().put(TracingWebFilter.SERVER_SPAN_CONTEXT, span.context());
            source.doOnCancel(() -> span.finish())
               .subscribe(new TracingSubscriber(subscriber, exchange, context, span, spanDecorators));
        }
    }

Happy to contribute if needed!

Thanks.

[geoand]

Hi,

that seems reasonable to me

[NHebrard]

@geoand Would you mind triggering a release?

[geoand]

I actually want the dust to setttle regarding the previous release, so why don't you ping me again please towards the end of the week?

[NHebrard]

This bug fix is somehow important for my team as we would like to have a complete trace visualization in the Jaeger UI. But, we can wait a few days more as the number of impacted spans is low.

Thanks!

[geoand]

Cool :)

[NHebrard]

Hello, Sorry to bother you again. Can we plan a release if there is no issue on your side?

Thanks!

[geoand]

Thanks for reminding me! Just launched it

[NHebrard]

Thanks for the new release!