search

opentracing / opentracing-java

OpenTracing API for Java. 🛑 This library is DEPRECATED! https://github.com/opentracing/specification/issues/163
http://opentracing.io
Apache License 2.0
1.68k stars 344 forks source link

V0.32.0 #337

Closed carlosalberto closed 5 years ago

carlosalberto commented 5 years ago

Hey - created a PR prior to releasing 0.32.0 (including updating the CHANGELOG).

Let me know ;)

felixbarny commented 5 years ago

Is this release fully backwards compatible?

tylerbenson commented 5 years ago

@felixbarny It should be compatible for users, but implementations will require some changes.

carlosalberto commented 5 years ago

Hey @felixbarny yes, it's as @tylerbenson said

As an exception: for users, they will be impacted if they use inject/extract with adapters themselves, i.e.

tracer.inject(context, Format.Builtin.TEXT_MAP, new TextMapInjectAdapter(map));

to:

tracer.inject(context, Format.Builtin.TEXT_MAP_INJECT, new TextMapInjectAdapter(map)); // Or...
tracer.inject(context, Format.Builtin.TEXT_MAP, new TextMapAdapter(map));
codefromthecrypt commented 5 years ago

Hey @felixbarny yes, it's as @tylerbenson said

As an exception: for users, they will be impacted if they use inject/extract with adapters themselves, i.e.

tracer.inject(context, Format.Builtin.TEXT_MAP, new TextMapInjectAdapter(map));

to:

tracer.inject(context, Format.Builtin.TEXT_MAP_INJECT, new TextMapInjectAdapter(map)); // Or...
tracer.inject(context, Format.Builtin.TEXT_MAP, new TextMapAdapter(map));

this should be added to the change log. can you do that? Also, It could be that TEXT_MAP_EXTRACT is also new? It is harder to tell without @since tags on the apis.

tylerbenson commented 5 years ago

@adriancole yes, both TEXT_MAP_INJECT and TEXT_MAP_EXTRACT were added in this release.