codefromthecrypt
commented
5 years ago @tylerbenson this is what we chatted about offline
Closed codefromthecrypt closed 5 years ago
codefromthecrypt
commented
5 years ago @tylerbenson this is what we chatted about offline
tylerbenson
commented
5 years ago @carlosalberto Do you have any concerns with this proposal? I think it's reasonable and we should move forward with this.
carlosalberto
commented
5 years ago @tylerbenson @adriancole Hey, hey,
So about releasing 0.33 right away, not sure (although it's expected to have this published relatively soon), but totally agree on removing from this point the deprecated members (including stuff like SpanBuilder.startManual())
tylerbenson
commented
5 years ago I think it would be good to consider 0.33.0 (1.0?) as the breaking change release. We could also consider changes that might improve future migration for the OT+OC project. I would expect a 1-2 month timeline for release seems reasonable. What do you think?
carlosalberto
commented
5 years ago Oh yeah, 0.33.0 should totally discard these methods.
1-2 month release seems reasonable for me, yes. I will create a PR in the next days to remove the aforementioned pieces.
carlosalberto
commented
5 years ago Closing as we released 0.33 already ;)
from a tracer implementation POV, 0.32 is as troublesome as 0.31 because the problematic apis are left in place, deprecated. I understand the bridge version concern, but currently we are on it and not over it.
It would be a good idea to release a 0.33 ASAP so that the tracer implementations can cleanup internals and maintenance, alleviating bugs and support around those methods. Instrumentation can switch-over to 0.33 or start fresh as 0.33.
It can be simple as sweeping out all deprecated methods and immediately cutting 0.33 now. Opposite of the intent of this issue would be waiting another 14 months for the next minor version, or releasing another with all the same things still around still deprecated.