search

opentracing / opentracing-php

OpenTracing API for PHP
Apache License 2.0
505 stars 56 forks source link

Add suffix for exceptions #104

Closed piotrooo closed 4 years ago

piotrooo commented 4 years ago

In almost all languages (it's some kind of best practice I think), exceptions has suffix Exception. Furthermore, in PHP, built-in exceptions also has that suffix.

Should we implement it?

jcchavezs commented 4 years ago

I think that is more like a usual practice rather than a best practice. I don't see it adding too much value to the code. Could you maybe provide more info on the benefits of doing so?

piotrooo commented 4 years ago

In every libray or project I have been involved into, there was this suffix used. This allows fast reach a context and make less confusion 'what exactly this class is - an exception or not'. As I said everybody (?) use this suffix, so maybe we can follow this standards?

jcchavezs commented 4 years ago

Agree on this. Could you please open a PR for this?