opentracing / opentracing-php

OpenTracing API for PHP
Apache License 2.0
505 stars 56 forks source link

Adds strict types and warning in ci #108

Closed jcchavezs closed 4 years ago

jcchavezs commented 4 years ago

Short description of what this PR does:

Checklist

Ping @cawolf @piotrooo @mszabo-wikia

jcchavezs commented 4 years ago

I don't seem to get the warnings here. Any clue @mszabo-wikia @piotrooo ?

mszabo-wikia commented 4 years ago

@jcchavezs I think this is because MockTracerTest::testInjectSuccess uses an injector callable that expects $carrier to be passed by value, rather than by reference, so it causes no warning. The warning is triggered when we change it to expect $carrier by reference (like a real-life injector would do).