fix: fixes the return type for withBaggageItems.

opentracing / opentracing-php

OpenTracing API for PHP

Apache License 2.0

505 stars 56 forks source link

fix: fixes the return type for withBaggageItems. #117

Closed jcchavezs closed 3 years ago

jcchavezs commented 3 years ago

As described in https://github.com/jcchavezs/zipkin-php-opentracing/pull/47/files/786ec41106b5905cfa7322fb54138c3289c1dce4#diff-97fcfff133419a8975edbc55468b44e719498b39a9a1f12b3f45ee7002d901e2

Note: This kind of errors are the ones which we should have avoided by try the implementation before doing the release.

nauxliu commented 3 years ago

This should consider be a breaking change, release it as v1.0.1 broke our application. If this project does not use Semantic Version, I'll need to lock this project at a specific version.