Add return type Traversable to getIterator for php8.1 compatibility

opentracing / opentracing-php

OpenTracing API for PHP

Apache License 2.0

505 stars 56 forks source link

Add return type Traversable to getIterator for php8.1 compatibility #120

Closed viteksafronov closed 2 years ago

viteksafronov commented 2 years ago

Short description of what this PR does:

Adds return type to OpenTracing/NoopSpanContext::getIterator() method

Checklist

[x] I have made a material change to the repo (functionality, testing, spelling, grammar)
[x] I have read the [Contribution Guide] and my PR follows them.
[x] I updated my branch with the master branch.
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation about the functionality in the appropriate .md file
[ ] I have added in line documentation to the code I modified

Closes #119

jcchavezs commented 2 years ago

I think we should cut a release only supporting 8.0 and 8.1

ecourtial commented 2 years ago

I think we should cut a release only supporting 8.0 and 8.1

That's tough. I humbly think we could gently wait for the PHP7 EOL in the end of the year before doing that.

viteksafronov commented 2 years ago

So can we merge it and release a new version?

viteksafronov commented 2 years ago

@jcchavezs sorry for explicit mention but we'd really appreciate it if these edits were released

jcchavezs commented 2 years ago

I am sorry I've been out. I will come back to this by tomorrow.

José Carlos Chávez

tir. 18. jan. 2022 kl. 17:21 skrev Victor Safronov @.***

:

@jcchavezs https://github.com/jcchavezs sorry for explicit mention but we'd really appreciate it if these edits were released

— Reply to this email directly, view it on GitHub https://github.com/opentracing/opentracing-php/pull/120#issuecomment-1015575900, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXOYAWWQ63AGAQECGFPF4DUWWHPNANCNFSM5L4TEE3A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

viteksafronov commented 2 years ago

@jcchavezs we are still waiting :( is there anyone else who can release these changes?

jcchavezs commented 2 years ago

In the end I added a patch release for this https://github.com/opentracing/opentracing-php/releases/tag/1.0.2

This did not introduce a breaking change.