search

opentracing / opentracing-php

OpenTracing API for PHP
Apache License 2.0
505 stars 56 forks source link

Adds null as a valid return value when calling SpanContext::getBaggageItem #19

Closed jcchavezs closed 7 years ago

jcchavezs commented 7 years ago

There is a not clear strategy for when calling SpanContext::getBaggageItem and there is not value for such key. Python API returns None (see https://github.com/opentracing/opentracing-python/blob/master/opentracing/span.py#L190) so we could safely return a null.

Ping @yurishkuro @felixfbecker @beberlei