Support tags injection via JAEGER_TAGS environment variable

opentracing / opentracing-php

OpenTracing API for PHP

Apache License 2.0

505 stars 56 forks source link

Support tags injection via JAEGER_TAGS environment variable #26

Closed otisg closed 6 years ago

otisg commented 7 years ago

For the sake of consistency, it would be useful if tags could be aggregated via JAEGER_TAGS environment variable like in the Java and, as of recently, Python clients.

pavolloffay commented 7 years ago

JAEGER_TAGS are jaeger specific. This is a vendor neutral API.

I am not aware of any OT API that supports tracer level tags. Maybe it's better to discuss it on the specification repo.

For the people who don't know what are JAEGER_TAGS https://github.com/uber/jaeger-client-java/tree/master/jaeger-core

jcchavezs commented 6 years ago

I think it is pretty clear that this is not something we could include in the OpenTracing library. Thanks @otisg for taking the time to proposing this issue, I encourage you to keep looking at this repository.