search

opentracing / opentracing-php

OpenTracing API for PHP
Apache License 2.0
505 stars 56 forks source link

Rename Ext to Tags #39

Closed yurishkuro closed 6 years ago

yurishkuro commented 6 years ago

I think it was a mistake in Go when we defined the standard tags in the ext package, it should've been called tags. My advise is to not repeat that mistake here.

Similarly, there can be a logs package for standard log fields.

taoso commented 6 years ago

Hi @yurishkuro , all the tags are just Conventions. They are recommend, not limit. Actually, the value of these tags does not matter at all. Choosing a different value of some tag has no influence on you code to interact with different implementations.

So put them in the Ext package really make sense.

jcchavezs commented 6 years ago

Closed by https://github.com/opentracing/opentracing-php/pull/47