[#43] Adds in process context propagation.

opentracing / opentracing-php

OpenTracing API for PHP

Apache License 2.0

505 stars 56 forks source link

[#43] Adds in process context propagation. #45

Closed jcchavezs closed 6 years ago

jcchavezs commented 6 years ago

This PR finally adds the in process context propagation, it is a simplified version of https://github.com/opentracing/opentracing-php/pull/20 integrating the Tracer and ActiveSpanSource interfaces and removing the access to the ActiveSpanSource object making it easier for implementors.

Open questions:

[ ] Should Tracer implement ActiveSpanSource or they should be separated interfaces and let the implementor to decide?

Ping @lvht @tedsuo @felixfbecker @beberlei @yurishkuro

taoso commented 6 years ago

I support not force the Tracer implement ActiveSpanSource and let the implementor to decide.

yurishkuro commented 6 years ago

cc @carlosalberto

jcchavezs commented 6 years ago

Closing this in favor of https://github.com/opentracing/opentracing-php/pull/47