issues
search
opentracing
/
opentracing-php
OpenTracing API for PHP
Apache License 2.0
505
stars
56
forks
source link
[#63] Adds default value for finish_span_on_close in scope manager activation
#66
Closed
jcchavezs
closed
6 years ago
jcchavezs
commented
6 years ago
Short description of what this PR does:
Adds a default value for
$finishSpanOnClose
in
ScopeManager::activate
.
Checklist
[x] I have made a material change to the repo (functionality, testing, spelling, grammar)
[x] I have read the [Contribution Guide] and my PR follows them.
[x] I updated my branch with the master branch.
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added in line documentation to the code I modified
Closes #63
Short description of what this PR does:
$finishSpanOnClose
inScopeManager::activate
.Checklist
Closes #63