opentracing / opentracing-php

OpenTracing API for PHP
Apache License 2.0
505 stars 56 forks source link

Introduce ignore_active_span option #68

Closed ellisv closed 6 years ago

ellisv commented 6 years ago

Both Tracer::startSpan() and Tracer::startActiveSpan() in implementation should start a new span as child of active span unless ignore_active_span option is set to true.

jcchavezs commented 6 years ago

@ellisv thanks for this! Could you please add some more information on why this is needed or maybe a link to the spec that describes this?

ellisv commented 6 years ago

@jcchavezs https://github.com/opentracing/specification/blob/master/rfc/scope_manager.md#tracer-changes

jcchavezs commented 6 years ago

Thoughts @yurishkuro @tedsuo @beberlei?

yurishkuro commented 6 years ago

Sgtm