search

openva / crump

A parser for the Virginia State Corporation Commission's business registration records.
https://vabusinesses.org/
MIT License
20 stars 3 forks source link

Deal with invalid shares_auth values #97

Closed waldoj closed 9 years ago

waldoj commented 9 years ago

In 4_amendments, we're seeing shares_auth values that are not numbers, as the field requires. We're seeing values like PREFER, PREF2 P, PVPREF, and CONVP. I have no idea of what these means. Figure out whether we need to replace these values with null values or whether we need to preserve these records, and eliminate the numeric constraint on this field.

waldoj commented 9 years ago

I'm not convinced that this is a Crump problem. The file spec says only this of the field:

3 HIST-OLD-SHARES-AUTH (N11) Shares Auth (Occurs 8 times)

There's no requirement that this field be numeric. I say the problem lies with vabusinesses.org, not Crump.

waldoj commented 9 years ago

D'oh—I forgot that we define the Elasticsearch maps in Crump. In that regard, this is a Crump problem.