[Good First Issue]: Align behavior of ONNX Frontend operator ReduceProd-11, 13, 18 with original framework

[gkrivor]

Context

Neural networks are graphs consisting of nodes called operators. Each operator corresponds to a mathematical function, usually described in framework's documentation or an AI standard, such as ONNX. OpenVINO ONNX Frontend is a component responsible for working with ONNX graphs and requires implementation of different ONNX operators in order to use ONNX models. This task requires alignment between OpenVINO ONNX Frontend and original framework implementations of ReduceProd for next list of opsets: opset 11, opset 13, opset 18 Necessary help will be provided by ONNX Fronted team.

What needs to be done?

First of all, please, take a look on ReduceMax PR for a reference.

Operator details can be found in ONNX Operators More details can be found in ONNX Changelog: opset 11, opset 13, opset 18

1. Operator already has a common implementation in OpenVINO. First of all, you need to review a documentation and prepare a table with differences between versions. It could be, for instance, a missing property, extended/reduced coverage of existing property, etc...
2. Copy existing implementation here to make it aligned with original framework (extend or reduce coverage of a common implementation). Copy of modified implementation should be in a defined opset, or in opset 1 in case it implements oldest implementation. Example of multi-opset operation.
3. Register the function in ops_bridge.cpp while keeping alphabetical order
4. Create test model(s) in ONNX models directory. OpenVINO test infrastructure then converts prototxt files to ONNX models - you will use those models later in tests
5. Add tests covering all use cases here
6. Check Python xfailed tests to find a test marked as a xfailed for added functionality. If any exist - remove corresponding lines and try to verify by using cmdline "python -m pytest -k name_of_test". More details in adding operators to ONNX Frontend guide

Example Pull Requests

No response

Resources

• Contribution guide - start here!
• Intel DevHub Discord channel - engage in discussions, ask questions and talk to OpenVINO developers
• What is OpenVINO?
• User documentation
• Guides on ONNX Frontend architecture and ONNX Frontend tests are also available
• You can also see a blog post on contributing to OpenVINO

Contact points

@gkrivor

Ticket

No response

[PulkitGarg777]

.take

[github-actions[bot]]

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

[p-wysocki]

Hi @PulkitGarg777, can we help you somehow?

[PulkitGarg777]

Hi @p-wysocki, sorry for not looking into it, been kinda busy. I've seen similar issues. I'll study them and if i get stuck somewhere, I'll surely let you know. Thank you for reaching out :)

[p-wysocki]

Hi @PulkitGarg777, are you still on that issue or can we reassign it to other contributors?

[PulkitGarg777]

You can reassign this issue, been busy with other work, my apologies

[mlukasze]

No worries, check us out in more convenient moment for you, we will wait :) I will reassign this ticket, but there will be more to train on.

[abhilashw]

.take

[github-actions[bot]]

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

[abhilashw]

Below are the differences between opset1 and opset11, opset13, opset18

[mlukasze]

@gkrivor take a look, please

[p-wysocki]

cc @gkrivor

[andrei-kochin]

@abhilashw so you have identified the difference Are you going to implement the code changes to have a generic implementation or do you need any additional feedback?

[abhilashw]

@andrei-kochin I was waiting for @gkrivor to provide feedback. Yeah I have made some changes to code. Working on adding testcases

[gkrivor]

@abhilashw hi, do you have any progress or I can take this task and complete?

[gkrivor]

.take

[github-actions[bot]]

Thanks for being interested in this issue. It looks like this ticket is already assigned to a contributor. Please communicate with the assigned contributor to confirm the status of the issue.