openwall / john-tests

Test Suite for John the Ripper
24 stars 15 forks source link

After changes in unique, .a simple /jtrts.pl fails #87

Closed claudioandre-br closed 4 years ago

claudioandre-br commented 4 years ago

After changes in unique, TS fails a regular run.

form=dynamic_0-raw                guesses: 1500 0:00:00:00 DONE  [PASSED]
Warning: The -mem=20 option is deprecated, use -hash-size=20 (log2 of hash
         table size) and/or -buf=1 (total buffer size, in GB) instead
Error: Requested hash size is unreasonably small (20, 1 M/8 MB)
Execute john (.pot check): ../run/john -ses=tst-  -pot=tst-.pot tst-tst.in --wordlist=tst-pw3 -form=dynamic_0  2>_stderr
.pot CHK:dynamic_0-raw            guesses:    0 -show=   0 N/A N/A : Expected count(s) (1500)  [!!!FAILED6!!!   ret_val=256 exited, return code 1]

https://github.com/openwall/john/commit/b2cfb8b3882946d8c5ad6ea99b8b16cddccd87b8

@jfoug, are you available?

solardiz commented 4 years ago

FWIW, the smallest memory allocation unique now allows is 256 MB with (undocumented) -buf=0. When used on tiny inputs, most of this address space is left unwritten, so doesn't use actual memory. Only the hash table is fully initialized, and by default that's 1/8 of total allocation (maybe we should increase that as higher hash table sizes produce better speeds on inputs that actually fill the buffer; the smaller allocation is to account for the case of small input, not to waste time and memory in that case).

Edit: typos.

solardiz commented 4 years ago

I didn't realize TS used that. I don't mind lowering the minimum allowed size back to 20. Should I, @claudioandre-br @jfoug?

claudioandre-br commented 4 years ago

TS needs love. But, if we have no perl volunteers, that have to be the solution.

solardiz commented 4 years ago

It doesn't really take a Perl volunteer to patch command-line options for an invoked program.

magnumripper commented 4 years ago

I can fix this. Actually I have no idea why TS use any options at all for unique.

magnumripper commented 4 years ago

f71347a