Closed claudioandre-br closed 4 years ago
FWIW, the smallest memory allocation unique
now allows is 256 MB with (undocumented) -buf=0
. When used on tiny inputs, most of this address space is left unwritten, so doesn't use actual memory. Only the hash table is fully initialized, and by default that's 1/8 of total allocation (maybe we should increase that as higher hash table sizes produce better speeds on inputs that actually fill the buffer; the smaller allocation is to account for the case of small input, not to waste time and memory in that case).
Edit: typos.
I didn't realize TS used that. I don't mind lowering the minimum allowed size back to 20. Should I, @claudioandre-br @jfoug?
TS needs love. But, if we have no perl volunteers, that have to be the solution.
It doesn't really take a Perl volunteer to patch command-line options for an invoked program.
I can fix this. Actually I have no idea why TS use any options at all for unique.
f71347a
After changes in unique, TS fails a regular run.
https://github.com/openwall/john/commit/b2cfb8b3882946d8c5ad6ea99b8b16cddccd87b8
@jfoug, are you available?