openwall / johnny

GUI frontend to John the Ripper password cracker
https://openwall.info/wiki/john/johnny
Other
537 stars 128 forks source link

Jumbo attack modes support #82

Closed mathsoft-dev closed 9 years ago

mathsoft-dev commented 9 years ago

It's sure that there are issues with this repetitive task since I didn't do a complete manual code review there and testing. But it is advanced enough to let you proceed to your usual style checkup/comments.

mathsoft-dev commented 9 years ago

Update : now I did testing and manual code review.

mathsoft-dev commented 9 years ago

I adressed your comments in bfd2a14 which contains a small mistake that I corrected in 01c02a6

mathsoft-dev commented 9 years ago

Can this be merged to proceed with #88 tomorrow and this week end ? I'll retest this PR to catch the latest bugs and improvements I could think of in the next hours.